Suggested improvements for the “TLS Keylog Launcher” feature
Summary
In RC 4.2 there is a new “SSL KEYLOG Launcher” feature under menu "Tools", but could IMO be improved:
- To make it really useful, the Launch button should start the capture and, when successful, then start the application. Specifically in that order; because otherwise I expect people will start questioning why they still cannot decrypt (because of missing TLS handshakes).
As it is now I guess that most users will launch the application, close the window and then start the capture. - Is the save button really required? The (Pre)-Master-Secret is stored in the preferences, which is saved when Wireshark is closed. That would be good enough for me.
- Typo: the environment variable is called SSLKEYLOGFILE (+FILE).
- Allow for command line arguments. I.e. start the browser with an URL as first argument launches it opening that website.
- Maybe add a button to kill the application. I.e. by default Chrome will keep a background process running when the windows are closed.
For Windows: taskkill /f /im $app_base_name /t
For Linux: pkill $app_base_name
Steps to reproduce
Not Applicable
What is the current bug behavior?
See above.
What is the expected correct behavior?
See above.
Sample capture file
Not Applicable
Relevant logs and/or screenshots
Build information
Version 4.3.0-AndreTest (v4.3.0rc0-604-gc6af671324a2).
Compiled (64-bit) using Microsoft Visual Studio 2022 (VC++ 14.33, build 31630),
with GLib 2.78.0, with Qt 6.6.0, with libpcap, with zlib 1.3.0, with PCRE2, with
Lua 5.2.4 (with UfW patches), with GnuTLS 3.7.9 and PKCS #11 support, with
Gcrypt 1.10.2-unknown, with Kerberos (MIT), with MaxMind, with nghttp2 1.57.0,
with nghttp3 1.0.0, with brotli, with LZ4, with Zstandard, with Snappy, with
libxml2 2.11.5, with libsmi 0.5.0, without QtMultimedia, with automatic updates
using WinSparkle 0.8.0, with AirPcap, with Minizip, with binary plugins.
Running on 64-bit Windows 11 (22H2), build 22621, with AMD Ryzen 7 5800H with
Radeon Graphics (with SSE4.2), with 32108 MB of physical memory, with GLib
2.78.0, with Qt 6.6.0, with Npcap version 1.71, based on libpcap version
1.10.2-PRE-GIT, with PCRE2 10.42 2022-12-11, with c-ares 1.18.1, with GnuTLS
3.7.9, with Gcrypt 1.10.2-unknown, with nghttp2 1.57.0, with nghttp3 1.0.0, with
brotli 1.0.9, with LZ4 1.9.3, with Zstandard 1.5.2, without AirPcap, with light
display mode, with HiDPI, with QPA plugin "windows", with LC_TYPE=English_United
Kingdom.utf8, binary plugins supported.
Edited by Peter Wu