f5ethtrailer: Infinite loop in legacy style dissector
Under certain circumstances the dissector will enter an infinite loop trying to dissect a trailer.
Steps to reproduce
f5ethtrailer.pref_walk_trailer: TRUE Malformed / corrupt packet such that heuristic signature matches possible legacy trailer, but a would be length field is larger than remaining bytes in TLV.
» tshark-git -o f5ethtrailer.pref_walk_trailer:TRUE -r trailer_walk_hang.pcap 1 0.000000 00:00:00_00:00:00 00:00:00_00:00:00 FILEINFO 296 tcpdump -vv -s0 -ni 0.0:nnn -w /var/tmp/guest-tmm.pcap (host 18.104.22.168 or host 10.194.80.6 or host 10.194.80.7 or host 10.194.80.8 or host 10.194.80.9 or host 10.194.80.10) 2 93.541785 10.178.128.52 51289 22.214.171.124 10133 35 UDP 1338 51289 → 10133 Len=205 ^C^Z  + 1076 suspended tshark-git -o f5ethtrailer.pref_walk_trailer:TRUE -r trailer_walk_hang.pcap
Can't SIGINT, must SIGKILL
What is the current bug behavior?
*shark fails to move past subject frame and spins in loop.
What is the expected correct behavior?
Dissector should bail out of dissection and reject the data.
Sample capture file
(If possible attach a sample capture file, not screenshot of dissection, showing this issue)
» tshark-git -v TShark (Wireshark) 4.1.0 (v4.1.0rc0-138-gdba3c64d6e74). Copyright 1998-2022 Gerald Combs <firstname.lastname@example.org> and contributors. Licensed under the terms of the GNU General Public License (version 2 or later). This is free software; see the file named COPYING in the distribution. There is NO WARRANTY; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Compiled (64-bit) using GCC 10.2.1 20210110, with GLib 2.66.8, with PCRE2, with zlib 1.2.11, with libpcap, with POSIX capabilities (Linux), with libnl 3, with Lua 5.2.4, without GnuTLS, with Gcrypt 1.8.8, with Kerberos (MIT), without MaxMind, without nghttp2, without brotli, with LZ4, with Zstandard, with Snappy, with libxml2 2.9.10, with libsmi 0.4.8, with binary plugins. Running on Linux 126.96.36.199-microsoft-standard-WSL2, with Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (with SSE4.2), with 25436 MB of physical memory, with GLib 2.66.8, with PCRE2 10.36 2020-12-04, with zlib 1.2.11, with libpcap 1.10.0 (with TPACKET_V3), with c-ares 1.17.1, with Gcrypt 1.8.8, with LZ4 1.9.3, with Zstandard 1.4.8, with libsmi 0.4.8, with LC_TYPE=en_US.UTF-8, binary plugins supported.