Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • wireshark wireshark
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 1.4k
    • Issues 1.4k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Wireshark FoundationWireshark Foundation
  • wiresharkwireshark
  • Issues
  • #17045
Closed
Open
Issue created Nov 30, 2020 by Chuck Craft@chuckcraftDeveloper

icmp.ident - separate combined column for be/le

Summary

O​S​Q​A (old Q&A site) - Some questions about ICMP dissection

Version 2.2.5 (v2.2.5-0-g440fd4d5)
icmp.ident Identifier (BE) Unsigned integer, 2 bytes 1.0.0 to 2.2.5
icmp.seq Sequence number (BE) Unsigned integer, 2 bytes 1.0.0 to 2.2.5
icmp.seq_le Sequence number (LE) Unsigned integer, 2 bytes 1.4.0 to 2.2.5

  1. When added as a column: icmp.seq and icmp.seq_le display two bytes and only one copy (be/le) which is properly formatted. icmp.ident displays both be and le in the same column
  2. None of them seem to sort properly when column header clicked in 2.2.5
  3. Is the ICMP dissector in a dll/binary or is there an ASCII file with its config?

Item 3 - What is packet-icmp.c for $500 Alex ?

Item 2 - fixed here? - Numeric Field values defined with BASE_UNIT_STRING do not sort numerically - commits to master-2.4 and master
Confirmed with downloads from all-versions that sorting works in 2.4.0 but not 2.2.17.

Item 1 - submitting !1082 (merged) to fix typo in hf_icmp_ident_le field definition

201129_icmp_ident_le

Original code added here: Clean up the icmp info column per discussion in bug #4014.
Clean up the icmp info column per discussion in bug #4014 (closed).

Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE in the proto_tree_add_item() calls for the identifier and sequence numbers.

#4014 (closed) ICMP: Add ID and seq # to Info column


Original question. Thanks to Chris for the detailed answer - was a bit over my head at that time.
And to @rknall for encouraging me at sf19us to open a bugzilla case.
A mere 18 months (or 3-1/2 years depending on how you count) I'm fixing it myself. :-)

201129_OSQA_ICMP_Ident

Edited Nov 30, 2020 by Chuck Craft
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking