1. 15 Apr, 2021 2 commits
  2. 14 Apr, 2021 2 commits
    • Guy Harris's avatar
      Clean up printing of interface information. · fcb56bd1
      Guy Harris authored
      In dumpcap, if we're being run by TShark or Wireshark, if there are no
      link-layer types, just provide an empty list to our caller; let them
      construct an empty list of link-layer types when they read our output.
      
      In the code that reads that list, don't report an error if the list is
      empty, rely on the caller to do so.
      
      Have capture_opts_print_if_capabilities() do more work, moving some
      functions from its callers to it.
      fcb56bd1
    • Guy Harris's avatar
      Wireshark: fix output of -L and --list-tstamp-types. · d6c3781a
      Guy Harris authored
      Replace the Wireshark code for that with code that matches what TShark
      does.
      
      Update a comment in TShark while we're at it.
      
      Fixes #14215.
      
      (Still leaves it popping up the full window, but that's a bigger
      change.)
      d6c3781a
  3. 13 Apr, 2021 2 commits
  4. 29 Mar, 2021 1 commit
    • João Valverde's avatar
      Merge the caputils/ and capchild/ directories · 7fee5027
      João Valverde authored
      The distinction between the different kinds of capture utility
      may not warrant a special subfolfer for each, and sometimes the
      distinction is not be clear or some functions could stradle
      multiple "categories" (like capture_ifinfo.[ch]).
      
      Simplify by having only a generic 'capture' subfolder. The
      separate CMake libraries are kept as a way to reuse object code
      efficiently.
      7fee5027
  5. 16 Mar, 2021 1 commit
    • Guy Harris's avatar
      Expand a comment. · a7d98a2c
      Guy Harris authored
      Give details on what happens when running Wireshark from a GUI on
      UN*Xes, or, at least, on {macOS,Ubuntu+GNOME,Ubuntu+KDE}, although
      it's probably similar on other UN*Xes and on other desktop environments.
      a7d98a2c
  6. 15 Mar, 2021 1 commit
    • Guy Harris's avatar
      Add more error-reporting routines that call through a function pointer. · c33e2f7b
      Guy Harris authored
      Have routines to report capture-file errors, using libwireshark error
      codes and strings, that call through a pointer, so they can pop up
      dialogs in GUI apps, print a message to the standard error on
      command-line apps, and possibly do something different on server
      programs.
      
      Have init_report_message() take a pointer to structure containing those
      function pointers, rather than the function pointers themselves, as
      arguments.
      
      Make other API changes to make that work.
      c33e2f7b
  7. 08 Mar, 2021 1 commit
    • Gerald Combs's avatar
      Remove modelines in ui/qt. · d3f17ee0
      Gerald Combs authored
      Remove the editor modeline blocks from most of the source files in ui/qt
      by running
      
          perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -g '\.(cpp|h)' )
      
      then cleaning up the remaining files by hand.
      
      This *shouldn't* affect anyone since
      
      - All of the source files in ui/qt use 4 space indentation, which
        matches the default in our top-level .editorconfig
      
      - The one notable editor that's likely to be used on these files and
        *doesn't* support EditorConfig (Qt Creator) defaults to 4 space
        indentation.
      d3f17ee0
  8. 06 Mar, 2021 1 commit
    • João Valverde's avatar
      if_capabilities: Use a structured error msg from dumpcap · 41a172cc
      João Valverde authored
      Have dumpcap in child mode return an error message with a primary and
      secondary string, instead of using stderr. When writing to the console
      log we ignore the second message to prevent flooding the log with
      tutorial-like info on permissions.
      41a172cc
  9. 19 Feb, 2021 2 commits
    • Guy Harris's avatar
      wiretap: eliminate two WTAP_FILE_TYPE_SUBTYPE_ values. · c80c1675
      Guy Harris authored
      Eliminate WTAP_FILE_TYPE_SUBTYPE_ERF and
      WTAP_FILE_TYPE_SUBTYPE_SYSTEMD_JOURNAL - instead, fetch the values by
      name, using wtap_name_to_file_type_subtype().
      
      This requires that wtap_init() be called before epan_init(); that's
      currently the case, but put in comments to indicate why it must continue
      to be the case.
      c80c1675
    • Gerald Combs's avatar
      Require Qt 5.6 or later. · abf9e027
      Gerald Combs authored
      Increase the minimum required version of Qt from 5.3 to 5.6. The various
      Linux distribution versions that shipped with earlier Qt versions (RHEL
      6, Fedora 23, openSUSE 13.2, Debian jessie, Ubuntu 16.04) have either
      reached end of support or will do so soon.
      
      The official Qt 5.6 releases for macOS require 10.8, so make that the
      minimum macOS version.
      
      Remove a bunch of no-longer-needed version checks.
      abf9e027
  10. 14 Feb, 2021 1 commit
    • Guy Harris's avatar
      Enable -Wredundant-decls. · c0711693
      Guy Harris authored
      Add it to the default list of checks, and fix some errors it causes.
      (Sadly, it doesn't work in CLang.)
      c0711693
  11. 31 Jan, 2021 1 commit
    • Guy Harris's avatar
      epan: have a routine to register all tap listeners. · 1f15c089
      Guy Harris authored
      Pull the code to register plugin taps, and the loop to register built-in
      taps, into a single register_all_tap_listeners() routine.
      
      This leaves it up to libwireshark, not to the programs using it, to know
      how to register them.
      1f15c089
  12. 19 Dec, 2020 1 commit
  13. 16 Dec, 2020 1 commit
  14. 06 Dec, 2020 1 commit
  15. 26 Oct, 2020 1 commit
  16. 25 Oct, 2020 1 commit
  17. 24 Oct, 2020 1 commit
  18. 20 Oct, 2020 1 commit
  19. 03 Oct, 2020 1 commit
    • Guy Harris's avatar
      Clean up URLs. · e013c5ec
      Guy Harris authored
      Add ui/urls.h to define some URLs on various of our websites.  Use the
      GitLab URL for the wiki.  Add a macro to generate wiki URLs.
      
      Update wiki URLs in comments etc.
      
      Use the #defined URL for the docs page in
      WelcomePage::on_helpLabel_clicked; that removes the last user of
      topic_online_url(), so get rid of it and swallow it up into
      topic_action_url().
      e013c5ec
  20. 05 Sep, 2020 1 commit
    • Gerald Combs's avatar
      Tools: Clean up checkAPI and add ui/qt. · 7ab64404
      Gerald Combs authored
      Remove the --check-addtext and --build flags. They were used for
      checkAddTextCalls, which was removed in e2735ecf.
      
      Add the sources in ui/qt except for qcustomplot.{cpp,h}. Fix issues in
      main.cpp, rtp_audio_stream.cpp, and wireshark_zip_helper.cpp.
      
      Rename "index"es in packet-usb-hid.c.
      7ab64404
  21. 14 Jul, 2020 1 commit
  22. 06 Jul, 2020 1 commit
    • Gerald Combs's avatar
      Windows: Set our locale to ".UTF-8". · 4dc3114c
      Gerald Combs authored
      In each of our executables we were calling "setlocale(LC_ALL, "")" at
      startup. This told Windows that output was encoded using the current
      system code page. Unless the code page was 65001 (UTF-8), this was a lie.
      
      We write UTF-8 to stdout and stderr, so call "setlocale(LC_ALL, ".UTF-8)"
      at startup on Windows. This lets the CRT translate our output correctly
      in more cases.
      
      Clarify and expand the OUTPUT section in the tshark man page.
      
      Bug: 16649
      Change-Id: If93231fe5b332c292946c7f8e5e813e2f543e799
      Reviewed-on: https://code.wireshark.org/review/37560
      
      
      Petri-Dish: Gerald Combs <gerald@wireshark.org>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: Gerald Combs's avatarGerald Combs <gerald@wireshark.org>
      4dc3114c
  23. 15 Feb, 2020 1 commit
  24. 07 Feb, 2020 1 commit
  25. 12 Jan, 2020 1 commit
  26. 09 Jan, 2020 1 commit
  27. 17 Nov, 2019 1 commit
  28. 03 Nov, 2019 1 commit
    • Gerald Combs's avatar
      Qt: Print qDebug messages by default. · f2036f0f
      Gerald Combs authored
      We handle Qt and GLib logging in the same handler, which means that if
      we map qDebug messages to G_LOG_LEVEL_DEBUG they won't be printed by
      default. This can make debugging the UI more confusing, since sprinkling
      in qDebug()s is a common Qt debugging method. If you're focused on
      fixing a bug it's easy to forget that you need to use qWarning() or
      change the logging level preference instead.
      
      Set the log level for qDebug messages to G_LOG_LEVEL_WARNING so that
      they show up.
      
      Change-Id: I4336b001cb667a31bf8b25306cd34e758cc8967e
      Reviewed-on: https://code.wireshark.org/review/34937
      
      Reviewed-by: Gerald Combs's avatarGerald Combs <gerald@wireshark.org>
      Petri-Dish: Gerald Combs <gerald@wireshark.org>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: Roland Knall's avatarRoland Knall <rknall@gmail.com>
      f2036f0f
  29. 27 Jul, 2019 1 commit
  30. 01 Jul, 2019 1 commit
  31. 11 Jun, 2019 2 commits
  32. 02 May, 2019 2 commits
  33. 01 May, 2019 1 commit
  34. 21 Feb, 2019 1 commit