1. 08 Mar, 2021 1 commit
    • Gerald Combs's avatar
      Remove modelines in ui/qt. · d3f17ee0
      Gerald Combs authored
      Remove the editor modeline blocks from most of the source files in ui/qt
      by running
      
          perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -g '\.(cpp|h)' )
      
      then cleaning up the remaining files by hand.
      
      This *shouldn't* affect anyone since
      
      - All of the source files in ui/qt use 4 space indentation, which
        matches the default in our top-level .editorconfig
      
      - The one notable editor that's likely to be used on these files and
        *doesn't* support EditorConfig (Qt Creator) defaults to 4 space
        indentation.
      d3f17ee0
  2. 19 Jan, 2021 1 commit
    • Guy Harris's avatar
      dup() can fail; check whether it does. · 165792fb
      Guy Harris authored
      If, for example, you run out of file descriptors, dup() can fail, and
      ws_dup() is a wrapper around it on UN*X.  Don't just pass the result of
      ws_dup() to ws_fdopen(); instead, save its result, check against -1 and,
      if it's -1, give up, otherwise pass it to ws_fdopen().
      
      This addresses Coverity CID 1471708.
      
      Also, if ws_fdopen() fails, close the descriptor we got from ws_dup();
      this closes a possible FD leak.
      165792fb
  3. 11 Jan, 2021 1 commit
    • j.novak@netsystem.cz's avatar
      Qt framework: Dialogs are correctly notified when capture file was closed · 8dd84917
      j.novak@netsystem.cz authored
      The patch reintroduces WiresharkDialog::captureFileClosed() method and
      calls captureFileClosing() and captureFileClosed() in right order.
      Both methods call updateWidgets() at its end.
      
      All dialogs were reviewed and captureFileClosing/Closed methods updated
      when appropriate.
      captureEvent() method in multiple dialogs changed to captureFileClosing/Closed
      as it does same actions - looks like old style of detecting of capture
      file closing.
      8dd84917
  4. 12 Dec, 2020 2 commits
  5. 01 Oct, 2020 1 commit
    • Gerald Combs's avatar
      Qt: Use … instead of UTF8_HORIZONTAL_ELLIPSIS in translated strings. · d2da4c7a
      Gerald Combs authored
      Run
      
      $ gsed -i -e 's/\(tr *(.*".*\)" *UTF8_HORIZONTAL_ELLIPSIS/\1…"/' $( ag -l 'tr *\(.*" *UTF8_HORIZONTAL_ELLIPSIS' )
      $ gsed -i -e 's/\(tr *( *\)UTF8_HORIZONTAL_ELLIPSIS *"/\1"…/' $( ag -l 'tr *\( *UTF8_HORIZONTAL_ELLIPSIS *"' )
      
      in ui/qt. As discussed in #16812, the UTF8_ macros were required at one
      time because we only allowed ASCII in our source code. However, that
      requirement has since been relaxed and Qt's translation framework
      doesn't handle concatenating strings and macros very well.
      d2da4c7a
  6. 06 Apr, 2020 1 commit
    • Jaap Keuter's avatar
      Qt: fix endpoint map file creation and presentation · 8b775781
      Jaap Keuter authored
      At least with Qt 5.12 on Debian/testing the following needs to be changed:
      - The temporary file name created for the endpoint map file needs to be
        retrieved at least once when the file is open to be available later on.
      - The temporary endpoint map file needs to remain on temporary storage
        because the external presentation process (web browser) needs to have
        access to it when it starts (asynchronously) and for as long as it needs.
      
      Change-Id: I554110a5a3ffa48b44575b1cb45f5971baac5e9c
      Reviewed-on: https://code.wireshark.org/review/36599
      
      Reviewed-by: AndersBroman's avatarAnders Broman <a.broman58@gmail.com>
      8b775781
  7. 24 Jan, 2020 1 commit
    • Guy Harris's avatar
      Fix the check for ws_fdopen() failure. · 0b64a3af
      Guy Harris authored
      If tf.handle() fails, it returns -1; we shouldn't call ws_fdopen() on
      its return value.  (I'm not sure whether it can fail, but this code is
      all a bit twisty.)
      
      If tf.handle() succeeds, and we hand its return value to ws_fdopen(),
      and we get back NULL, *that* indicates that ws_fdopen() failed.
      
      This should fix Coverity CID 1457929, preventing a FILE leak.
      
      Change-Id: I23bb04579d26928037f8b9284b7741affc3596f7
      Reviewed-on: https://code.wireshark.org/review/35940
      
      
      Petri-Dish: Guy Harris <guy@alum.mit.edu>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: default avatarGuy Harris <guy@alum.mit.edu>
      0b64a3af
  8. 20 Dec, 2019 1 commit
  9. 17 Mar, 2019 1 commit
  10. 16 Feb, 2019 1 commit
    • Peter Wu's avatar
      Re-implement "Map" feature for Endpoints · ba1ef0ec
      Peter Wu authored
      This feature was removed in v2.5.1rc0-427-gf529ab5d, anticipating that
      MaxMind would remove support for it in 2019. They have however changed
      their mind and maintained latitude and longitude information.
      
      They recommend displaying an accuracy radius, but the reported values
      are 50, 100, 200 and 1000km. When implemented literally, a marker in
      Ireland would cover the whole island plus mainland, so I have instead
      opted to use a fixed radius of 1km at deeper zoom levels.
      
      The old ipmap.html file was outdated and had broken tiles, I rewrote a
      new one from scratch using the light-weight Leaflet library combined
      with tiles from OpenStreetMap. This is more mobile-friendly and secure
      (https, SRI). To improve handling of nearby or overlapping nodes,
      clustering is used (individual nodes can still be inspected).
      
      Browser compatibility results: IE8 is unusable, IE9 partially works
      (tooltips sometimes disappear and the cluster radius control is gone),
      IE11 works. Of course Fir...
      ba1ef0ec
  11. 11 Feb, 2019 1 commit
  12. 08 May, 2018 1 commit
  13. 01 May, 2018 1 commit
  14. 06 Mar, 2018 1 commit
    • Gerald Combs's avatar
      Transition from GeoIP Legacy to MaxMindDB. · a1da75c5
      Gerald Combs authored
      MaxMind is discontinuing its legacy databases in April in favor of
      GeoIP2, which use a newer database format (MaxMind DB). The reference C
      library (libmaxminddb) is available under the Apache 2.0 license which
      isn't quite compatible with ours.
      
      Add mmdbresolve, a utility that reads IPv4 and IPv6 addresses on stdin
      and prints resolved information on stdout. Place it under a liberal
      license (MIT) so that we can keep libmaxminddb at arm's length. Add
      epan/maxmind_db.[ch], which spawns mmdbresolve and communicates with it
      via stdio.
      
      Migrate the preferences and documentation to MaxMindDB.
      
      Change the IPv4 and IPv6 asnum fields to FT_UINT32s. Change the
      geographic coordinate fields to FT_DOUBLEs.
      
      Bug: 10658
      Change-Id: I24aeed637bea1b41d173270bda413af230f4425f
      Reviewed-on: https://code.wireshark.org/review/26214
      
      
      Petri-Dish: Gerald Combs <gerald@wireshark.org>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: Gerald Combs's avatarGerald Combs <gerald@wireshark.org>
      a1da75c5
  15. 02 Mar, 2018 1 commit
    • Gerald Combs's avatar
      Remove the endpoint "Map" feature. · f529ab5d
      Gerald Combs authored
      Remove the endpoint map and its button from the Qt and GTK+ UIs. It
      depends on GeoIP Legacy for coordinate information and those databases
      are being deprecated in favor of MaxMind DB. We *could* upgrade the code
      to use mmdbresolve, but according to
      https://dev.maxmind.com/geoip/geoip2/geolite2/ they're also going to
      remove coordinate information from GeoLite2:
      
      "In addition, in 2019, latitude and longitude coordinates in the
       GeoLite2 databases will be removed.* Latitude and longitude coordinates
       will continue to be provided in GeoIP2 databases. Please check back for
       updates."
      
      Change-Id: I43e1593d282a0f1aae897b1f4724117d1496b21e
      Reviewed-on: https://code.wireshark.org/review/26229
      
      
      Petri-Dish: Gerald Combs <gerald@wireshark.org>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: Gerald Combs's avatarGerald Combs <gerald@wireshark.org>
      f529ab5d
  16. 08 Feb, 2018 1 commit
  17. 02 Feb, 2018 1 commit
  18. 04 Dec, 2017 1 commit
  19. 03 Dec, 2017 1 commit
    • Guy Harris's avatar
      Use cfile.h to define the capture_file type. · eb8ffb74
      Guy Harris authored
      Have cfile-int.h declare the structure, and use it in files that
      directly access the structure.
      
      Have cfile.h just incompletely declare the structure and include it
      rather than explicitly declaring it in source files or other header
      files.
      
      Never directly refer to struct _capture_file except when typedeffing
      capture_file.
      
      Add #includes as necessary, now that cfile.h doesn't drag in a ton of
      
      Change-Id: I7931c8039d75ff7c980b0f2a6e221f20e602a556
      Reviewed-on: https://code.wireshark.org/review/24686
      
      Reviewed-by: default avatarGuy Harris <guy@alum.mit.edu>
      eb8ffb74
  20. 29 Oct, 2017 1 commit
  21. 26 Oct, 2017 1 commit
  22. 31 Aug, 2017 1 commit
  23. 26 Jul, 2017 1 commit
    • Roland Knall's avatar
      Qt: Move utils to separate utils directory · ddfc1d37
      Roland Knall authored
      Following the move for widgets directory, moving utils
      to the utils directory. Guidelines for this directory are:
      
       - Generic use but not a widget
       - Utility functionality used by many classes
       
       Note: additionally all includes affected by this move have been changed
       to absolute path includes, instead of relative ones.
      
      Change-Id: I019ae4b6e6f6d06a5745a63ed195edbd36fb936b
      Reviewed-on: https://code.wireshark.org/review/22602
      
      
      Petri-Dish: Roland Knall <rknall@gmail.com>
      Reviewed-by: Roland Knall's avatarRoland Knall <rknall@gmail.com>
      ddfc1d37
  24. 26 Apr, 2017 1 commit
  25. 06 Mar, 2017 1 commit
  26. 14 Sep, 2016 1 commit
  27. 27 Jun, 2016 2 commits
  28. 26 Jun, 2016 1 commit
  29. 23 Jun, 2016 1 commit
  30. 22 Jun, 2016 2 commits
  31. 23 Apr, 2016 1 commit
  32. 21 Apr, 2016 1 commit
  33. 21 Jan, 2016 1 commit
  34. 12 Jan, 2016 1 commit
  35. 26 Aug, 2015 2 commits
  36. 29 Jul, 2015 1 commit