1. 10 Aug, 2022 1 commit
    • John Thacker's avatar
      HTTP: Speed up chunked Transfer-Encoding on TCP · 13df9b0b
      John Thacker authored and A Wireshark GitLab Utility's avatar A Wireshark GitLab Utility committed
      HTTP/1.1 chunked Transfer-Encoding doesn't have a overall length,
      but requires scanning through variable length chunks to find the
      end. If we determine that additional segments are needed, and
      we have a sequence number (or other identifier) for the message,
      store the position of the last chunk size found.
      
      Use this to start scanning at that same offset when the next
      segment arrives, reducing the algorithm for determining if
      when we have the complete chunked message from O(N^2) to O(N),
      which can be significant on captures with many chunks.
      
      This does most of #14382, reducing the length of time to process
      a file with 2 pass tshark from over 8.5 secs to under 3 seconds
      on my machine. There is still some O(N^2) contribution from the
      reassembly code itself with many small fragments (see #17311).
      
      Other dissectors need some small changes to enable this for
      HTTP over other transport layers. (TLS would be fairly easy and
      is the other important case.)
      13df9b0b
  2. 09 Aug, 2022 1 commit
    • John Thacker's avatar
      prefs: More cleanup, auto prefs · 203cd2cb
      John Thacker authored and AndersBroman's avatar AndersBroman committed
      Remove callback function from pref registrations for dissectors that
      don't need a callback. In other dissectors, move registration that
      only needs to be done once inside the check for initialization,
      avoiding some console messages when preferences are changed
      ("Duplicate dissectors (anonymous) and (anonymous) for protocol...")
      and the like.
      
      Add a couple auto preferences for dissectors missed in previous waves.
      
      Ping #14319
      203cd2cb
  3. 20 Jun, 2022 1 commit
  4. 10 Jun, 2022 1 commit
  5. 24 May, 2022 2 commits
  6. 11 May, 2022 1 commit
  7. 31 Jan, 2022 1 commit
  8. 26 Jan, 2022 1 commit
  9. 19 Dec, 2021 3 commits
  10. 20 Oct, 2021 1 commit
  11. 13 Oct, 2021 1 commit
  12. 11 Sep, 2021 1 commit
    • Guy Harris's avatar
      Fix spelling errors. · 76b08ea0
      Guy Harris authored
      The Ubuntu build commented on some spelling errors in executable code
      files.  Fix the errors that don't come from external files containing
      the spelling errors (USB product and vendor IDs, PCI IDs, ASN.1
      specifications), and fix some errors that don't show up in the
      executable code files (e.g., in comments and variable names).
      76b08ea0
  13. 01 Sep, 2021 1 commit
    • Evan Huus's avatar
      tvbuff: convert helper methods to pinfo->pool · cdfab0d6
      Evan Huus authored and AndersBroman's avatar AndersBroman committed
      A few of them just needed scratch memory, so allocate and free it
      manually after doing any exception-raising checks.
      
      A few others were returning memory, and needed conversion to accept a
      wmem scope argument.
      cdfab0d6
  14. 03 May, 2021 1 commit
  15. 30 Apr, 2021 1 commit
    • Guy Harris's avatar
      Cast away the return value of g_strlcpy() and g_strlcat(). · 57a1514a
      Guy Harris authored
      Most of the time, the return value tells us nothing useful, as we've
      already decided that we're perfectly willing to live with string
      truncation.  Hopefully this keeps Coverity from whining that those
      routines could return an error code (NARRATOR: They don't) and thus that
      we're ignoring the possibility of failure (as indicated, we've already
      decided that we can live with string truncation, so truncation is *NOT*
      a failure).
      57a1514a
  16. 28 Apr, 2021 1 commit
  17. 01 Apr, 2021 1 commit
  18. 27 Mar, 2021 1 commit
    • j.novak@netsystem.cz's avatar
      Follow SIP Call: Added Follow SIP Call to Follow menu · e75e1fb5
      j.novak@netsystem.cz authored and A Wireshark GitLab Utility's avatar A Wireshark GitLab Utility committed
      Changes:
      - epan/follow.c: follow_conv_filter_func has new parameter
        epan_dissect_t *edt, so filter can be generated based on decoded tree
      of packet below the cursor
      - menu Follow/SIP Call is enabled when sip packet is selected
      - value of sip.Call-ID is used as filter for SIP call
      - for sharkd it generates filter just 'sip.Call-ID' with no value
      e75e1fb5
  19. 07 Feb, 2021 1 commit
    • Martin Kaiser's avatar
      sip: populate stats tables' rows only once · 881941e2
      Martin Kaiser authored and AndersBroman's avatar AndersBroman committed
      Sip uses two different statistics tables. We check for each one if it
      already exists. If so, we don't populate the rows again, we just clear
      the data that was collected when the tap parsed the packets.
      
      Fixes: b00c3bd7 ("sip: create the statistics tables only once")
      881941e2
  20. 04 Feb, 2021 1 commit
  21. 31 Jan, 2021 1 commit
  22. 13 Jan, 2021 1 commit
  23. 03 Oct, 2020 1 commit
  24. 27 Sep, 2020 1 commit
    • Martin Mathieson's avatar
      Fix some wrong filter names. · 08ab0e5d
      Martin Mathieson authored and AndersBroman's avatar AndersBroman committed
      These were detected by running check_typed_item_calls.py
      with --consecutive, which flags items that have different
      labels but the same filter string.  Usually this is because
      of copy/paste.
      
      Quite a few similar bugs still exist, will address in a future commit.
      08ab0e5d
  25. 10 Sep, 2020 1 commit
  26. 31 Aug, 2020 1 commit
  27. 12 Apr, 2020 2 commits
  28. 16 Feb, 2020 1 commit
  29. 13 Feb, 2020 1 commit
    • Orgad Shaneh's avatar
      Introduce AudioCodes Debug Recording (ACDR) dissector · 32679c14
      Orgad Shaneh authored and Peter Wu's avatar Peter Wu committed
      ACDR is a protocol over UDP that is used by AudioCodes devices for
      recording traffic to and from the device.
      
      It adds a header to each packet that contains extra data about the packet.
      
      For some packet types (like SIP), it also appends the IP and UDP/TCP
      headers of the sent/received packet.
      
      The dissector unwraps the ACDR header, and displays the packets with the
      original type (and when available, with the original addresses).
      
      Bug: 16275
      Change-Id: I19ad90053a2ef73da80881dc5e94aa362de23ea3
      Reviewed-on: https://code.wireshark.org/review/35417
      
      
      Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: Peter Wu's avatarPeter Wu <peter@lekensteyn.nl>
      32679c14
  30. 11 Feb, 2020 1 commit
  31. 24 Jan, 2020 1 commit
  32. 05 Jan, 2020 1 commit
  33. 30 Dec, 2019 1 commit
  34. 18 Nov, 2019 1 commit
  35. 26 Aug, 2019 1 commit
  36. 26 Jul, 2019 1 commit