1. 15 Jan, 2021 5 commits
  2. 28 Nov, 2019 1 commit
    • Stefan Tatschner's avatar
      Change struct can_identifier to can_info · 40eece98
      Stefan Tatschner authored
      The can specific data structure `struct can_identifier` is used as
      supplementary data for higher level dissectors. This patch adds more
      data to this struct and renames it accordingly to `struct can_info`.
      
      More supplementary data is needed in order to dissect iso15765
      correctly, since the header format depends on details on the underlying
      CAN protocol (CAN 2.0B vs CAN-FD).
      
      Change-Id: Id068cf38453f98b67a5ec470a22e7013548c5a14
      Reviewed-on: https://code.wireshark.org/review/35246
      
      
      Petri-Dish: Guy Harris <guy@alum.mit.edu>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: default avatarGuy Harris <guy@alum.mit.edu>
      40eece98
  3. 19 Aug, 2019 1 commit
  4. 26 Jul, 2019 1 commit
  5. 13 Jan, 2019 1 commit
    • Maksim Salau's avatar
      dissectors: can: Handle CAN id flags · eaee7079
      Maksim Salau authored
      The change adds support of CAN flags stored in ids.
      The flags allow dissectors to distinguish error frames,
      remote transmission request frames and identify id type used (either
      standard 11-bit or extended 29-bit).
      
      Addition of bit flags allowed to add more checks whether a CAN frame may
      be decoded by a particular dissector. I.e. some dissectors work only
      with 11-bit ids (CANopen, DeviceNet) some only with 29-bit (J1939,
      ISObus), others should be fine with bot types (OBD-II, ISO 15765).
      
      The change also fixes 2 bugs in the DeviceNet dissector:
      * removed byte swapping of CAN id (the pcap file seems to be broken;
        verified dissector operation with random traffic generated by cangen)
      * fixed "Warn Dissector bug, protocol DeviceNet, in packet N":
        added a default value for fragmented message type string value lookup.
      
      Bug: 15418
      Change-Id: I70e91130789bb3367fe19e51489cd34e97d678a6
      Reviewed-on: https://code.wireshark.org/review/31471
      
      
      Petri-Dish: Anders Broman <a.broman58@gmail.com>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: AndersBroman's avatarAnders Broman <a.broman58@gmail.com>
      eaee7079
  6. 19 Apr, 2018 1 commit
    • Alexandr Savca's avatar
      Fix cppcheck 1.83 warnings · b545c606
      Alexandr Savca authored
      [packet-ber.c:2687]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
      [packet-erf.c:2475]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
      [packet-fmp.c:378]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
      [packet-http2.c:2050]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
      [packet-obd-ii.c:643]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
      [packet-yami.c:244]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
      
      Change-Id: Ie71f9f7c8f863d1e9c693bd56444f00bdad48042
      Reviewed-on: https://code.wireshark.org/review/27019
      
      Reviewed-by: Peter Wu's avatarPeter Wu <peter@lekensteyn.nl>
      Petri-Dish: Peter Wu <peter@lekensteyn.nl>
      Reviewed-by: default avatarGuy Harris <guy@alum.mit.edu>
      Tested-by: Petri Dish Buildbot
      b545c606
  7. 12 Feb, 2018 1 commit
  8. 18 May, 2017 1 commit
  9. 14 May, 2017 1 commit