Johannes Berg pointed out this was the intent of the TLV definitions and
supplied some code for implementing that. I simply made it work.

Dario Lombardo authored Jan 15, 2022 and Jaap Keuter committed Jan 15, 2022

Data from packet has been used as encoding instead of an actual
encoding. Fix by using ENC_NA, since the field is FT_UINT8.

Fix: #17878.

Use macros from inttypes.h with format strings.

Richard Sharpe authored Dec 14, 2021 and A Wireshark GitLab Utility committed Dec 15, 2021

The code was not advancing the offset correctly and mis-dissecting NDP
frames.

Richard Sharpe authored Dec 12, 2021 and A Wireshark GitLab Utility committed Dec 13, 2021

The dissector was not correctly handling the Tag and Length.

Mostly longer masks with odd numbers of digits.

Automated find/replace of wmem_packet_scope() with pinfo->pool in all
files where it didn't cause a build failure.

Radiotap doesn't supply a channel number, just a center frequency, so
the latter is what we use to guess the modulation.

Do more fixups of the "phy" based on the data rate, so that it reflects
the modulation used for the packet.

Note, in comments, why we're doing this, and that there's no reiable
way, in radiotap, to determine the type of channel on which capturing is
being done, as some packet providers use the channel field to indicate
the channel type and others use it to indicate the modulation.

Only provide the "short preamble" for "11b", as that's now being used to
mean "DSSS modulation" - packets on an 11g channel will be marked as
"11g" if they're OFDM or "11b" if they're DSSS.

Make some other cleanups while we're at it.

It's 802.11-specific, and may include non-frequency/channel-related
items in the future.

Alexis La Goutte authored Feb 06, 2021 and AndersBroman committed Feb 07, 2021

packet-ieee80211-radiotap.c:2190:3: warning: Value stored to 'offset' is never read

Richard Sharpe authored Jan 02, 2021 and A Wireshark GitLab Utility committed Feb 01, 2021

S1G adapters should be shipping soon since Silex America has a dev-kit
available, so it is about time to add support for this.

Change-Id: I0225d87f78efbcbe88476921d4fce3d56a3ce0cd

Martin Mathieson authored Oct 03, 2020 and Martin Mathieson committed Oct 03, 2020

These appear to be copy/paste errors detected by running
./tools/check_typed_item_calls.py --consecutive

Quite a few issues still remain after this batch.

Martin Mathieson authored Aug 29, 2020 and Dario Lombardo committed Aug 29, 2020

A second batch of spelling errors, detected using a script
that uses pyspellcheck and a Wireshark-specific dictionary file.

I will take at least one more pass through the dissectors, as
further improvements are made to the script.

Anonymous authored Jul 14, 2020 and AndersBroman committed Aug 10, 2020

This patches adds support to parse the TX flags of the radiotap header,
including a new DONT_ORDER Tx flag.

Bug: 16732
Change-Id: Ia57c079e020a32219a3e3fcfb7da5ef260360b7e
Reviewed-on: https://code.wireshark.org/review/37944


Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Guy Harris authored Jun 18, 2020 and AndersBroman committed Jun 19, 2020

The static arrays are supposed to be arrays of const pointers to int,
not arrays of non-const pointers to const int.

Fixing that means some bugs (scribbling on what's *supposed* to be a
const array) will be caught (see packet-ieee80211-radiotap.c for
examples, the first of which inspired this change and the second of
which was discovered while testing compiles with this change), and
removes the need for some annoying casts.

Also make some of those arrays static while we're at it.

Update documentation and dissector-generator tools.

Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc
Reviewed-on: https://code.wireshark.org/review/37517


Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Another instance of this problem that showed up when working on the fix
to the data types of those tables (fixing the data types mean that these
errors cause the conpile to fail; as indicated, that's one reason to fix
them).

Change-Id: Ia1953b95968101f27fedd98a5fc2854101779deb
Reviewed-on: https://code.wireshark.org/review/37509

Reviewed-by: Guy Harris <gharris@sonic.net>

The arrays of pointers to header field hf_ values were getting
overwritten if the fields in question are unknown; that meant that, in
all future dissections, they would be dissected as unknown *even for
packets where they are known*.

Make them auto arrays, instead, so that each call to the dissector has
its own copy, properly initialized at run time, that it can scribble
over as it chooses without damaging the array for the next call.

This involves a cast to work around the type of the array argument being
"const int **", which means "pointer to pointer to const int",
not "pointer to const pointer to (non-const) int".  That meant that the
scribbling on the static array was *not* detected at compile time.

Fixing the type is a *lot* of work, but may catch other instances of
this problem, and may prevent future instances of it.  That's a project
for a separate commit, however.

Bug: 16636
Change-Id: I985157063488739bb59f87780c017e94e2380343
Reviewed-on: https://code.wireshark.org/review/37502


Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>

Prof. Doppler's name is spelled with two "p"s.

Change-Id: Ia25d45b0a890be8c954a67b1ce5860753c1de25d
Reviewed-on: https://code.wireshark.org/review/37498

Reviewed-by: Guy Harris <gharris@sonic.net>

Glenden Lee authored May 27, 2020 and Guy Harris committed May 27, 2020

Bug: 16255 - support HE MCS to rate conversion
Change-Id: I4a4a6c3d62c167b654d150c397047a55f287e6c8
Reviewed-on: https://code.wireshark.org/review/37255


Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>

Tomáš Kukosa authored May 13, 2020 and Alexis La Goutte committed May 14, 2020

Change-Id: I49f1bd88b887635b2404e15dac60a44963ff9fd7
Reviewed-on: https://code.wireshark.org/review/37188


Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Dario Lombardo authored Feb 10, 2020 and Alexis La Goutte committed Feb 10, 2020

Change-Id: I7f94e0d8ccb6650d6ace0a119e7f92045a26b338
Reviewed-on: https://code.wireshark.org/review/36070

Reviewed-by: Dario Lombardo <lomato@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Dario Lombardo authored Feb 09, 2020 and AndersBroman committed Feb 10, 2020

Change-Id: I684b3e59c97f45afaf1d4bdfd160a03e4e87b0f1
Reviewed-on: https://code.wireshark.org/review/36064


Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>

Richard Sharpe authored Feb 08, 2020 and Alexis La Goutte committed Feb 08, 2020

From Johannes Berg with changes by Richard Sharpe to make it easier for
people to add support for RADIOTAP Header TLVs in the future.

Change-Id: I66d69cbe16740abce1e75ca1e789a2034283306b
Reviewed-on: https://code.wireshark.org/review/36057

Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

The range doesn't start at 60 GHz, it starts at 57 GHz; this fixes that,
and leaves it open to future fixes.

Change-Id: I51d7188f50479bf542babe0f6677638e8a683314
Reviewed-on: https://code.wireshark.org/review/35524


Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

This works around the lack of a defined radiotap field for 11ad.

Bug: 16272
Change-Id: Ia851c644aee52ff9a138a36b16015d4112b5bf92
Reviewed-on: https://code.wireshark.org/review/35401


Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Set it as the PHY type if we see the HE field in a radiotap header, and
report that PHY type as "802.11ax" in the generic radio metadata
dissector.

Change-Id: I181d2717d82bdca73e04b6111b2483ca099d48bb
Ping-Bug: 13207
Reviewed-on: https://code.wireshark.org/review/35227


Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Sebastien Deronne authored Sep 11, 2019 and mmann78 committed Sep 14, 2019

(patch from Getachew Redieteab)

Change-Id: I180b20b513e901c2c157da9a2318a90c91fd040b
Reviewed-on: https://code.wireshark.org/review/34505

Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>

Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089

Reviewed-by: Guy Harris <guy@alum.mit.edu>

Gerald Combs authored Apr 03, 2019 and AndersBroman committed Apr 04, 2019

Convert our various PROTO_ITEM_ macros to inline functions and document
them.

Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c
Reviewed-on: https://code.wireshark.org/review/32706

Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

The spec is now accepted, so bringing these up to date.

Change-Id: I9489cd8c0b9255446c829f8202410d2d94272607
Reviewed-on: https://code.wireshark.org/review/31723


Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>

Change-Id: I6fa9593af64e8af1ade4f049ea949989adfd00c7
Reviewed-on: https://code.wireshark.org/review/30595

Reviewed-by: Guy Harris <guy@alum.mit.edu>

Those frames *don't* have their link-layer headers stripped, even on
PF_PACKET/SOCK_DGRAM captures (hopefully, nobody will consider that a
bug and "fix" it).

The "hatype" field is the ARPHRD_ value for the adapter, as returned by
SIOCGIFHWADDR; in monitor mode, those frames will have an hatype of
ARPHRD_IEEE80211_RADIOTAP.  Add an "sll.hatype" dissector table, which
we check before checking the "sll.ltype" dissector table, and have the
radiotap dissector register in that table.

We still use the special hack for an hatype of ARPHRD_NETLINK, because,
for *those* frames, the "protocol" field of the nominal SLL header is
the netlink family, not an Ethertype or anything else that the SLL
dissector would handle.

Change-Id: If503a7daa9133adf1b8c330ec28c4c824d4f551d
Reviewed-on: https://code.wireshark.org/review/30592

Reviewed-by: Guy Harris <guy@alum.mit.edu>

1) it doesn't supply any information not supplied by the new
"wlan_radio" tap and, in fact, supplies less information (including not
supplying any presence flags);

2) it only works for radiotap headers, not for any other forms of radio
metadata;

3) its data structure wasn't declared in a header available to any
listeners, it was defined internally to the radiotap dissector.

Change-Id: Ie84a48bbf204b8b3bb40370c17ca82d39e5df3fb
Reviewed-on: https://code.wireshark.org/review/30415

Reviewed-by: Guy Harris <guy@alum.mit.edu>

The radiotap spec says "dB antenna signal" and "dB antenna noise" are
unsigned.  Make it universally so.

Change-Id: Iea2c5360d7352ca5e84862ea338d1fc689272191
Reviewed-on: https://code.wireshark.org/review/30410

Reviewed-by: Guy Harris <guy@alum.mit.edu>