GitLab

It is supposed to be 0x8298 according to both the TIFF and Exif specs.

IFD is the structure these variables refer to, and is short for
Image File Directory.

Роман Донченко authored Sep 23, 2021 and Wireshark GitLab Utility committed Sep 24, 2021

An Exif file typically contains 2 IFDs, and this makes them easier to tell
apart.

João Valverde authored Sep 23, 2021 and Wireshark GitLab Utility committed Sep 24, 2021

Use something a bit more modern instead.

The memory block the error was written to was uninitialized

Uli Heilmeier authored Sep 21, 2021 and Wireshark GitLab Utility committed Sep 24, 2021

Generating and calculating JA3 and JA3S based on Client Hello and Server Hello
values to fingerprint TLS clients and servers.

JA3(S) is documented at https://github.com/salesforce/ja3

Fixes: wireshark/wireshark#17595

wireshark\capture\capture-wpcap.c:901:42: error: expected ';', ',' or ')' before '_U_'
 get_runtime_caplibs_version(GString *str _U_)
                                          ^~~

Gerald Combs authored Sep 22, 2021 and Wireshark GitLab Utility committed Sep 23, 2021

Clean up some list items and a quote.

Gerald Combs authored Sep 22, 2021 and Wireshark GitLab Utility committed Sep 23, 2021

Reverse the text added in cdd6f2ec and note that we can't yet use
Asciidoctor.js to build our documentation. I'm not sure how I managed to
miss this in my initial tests, but Asciidoctor.js is missing Docbook,
PDF, and EPUB backends, and doesn't support Ruby macros.

Provide Internet Archive links for dead URLs.
Update to note that PSML output is supported by tshark and not
a future feature (true since 17 years ago, when it was still tethereal).
Note "fake-field-wrapper" protocol for top level fields (including data,
which is converted from a protocol to a field for PDML).
Note "_ws.expert" protocol replaced by field, as with data.
Note that some dissectors place subdissected protocols in subtrees
instead of at the top level, and that this is _not_ changed, violating
the PDML spec.
Fix #10588.

João Valverde authored Jul 16, 2021 and Wireshark GitLab Utility committed Sep 22, 2021

Build output must not be placed in run/<config>/subdir.

This should be done using CMAKE_GENERATOR_IS_MULTI_CONFIG instead of just
MSVC but that wasn't working for me when I tried briefly.

João Valverde authored Sep 22, 2021 and Wireshark GitLab Utility committed Sep 22, 2021

This is applicable to every test (if we had more), not just HAVE_C99_VSNPRINTF.

Could also be a #define but let's go with this for now. This takes
advantage of the stack based design of CMakePushCheckState.

MINGW implies WIN32 which implies CMake >= 3.13.

Follow-up to 1dad8190.

Defining _POSIX enables __USE_MINGW_ANSI_STDIO, this switches the
stdio API from Microsoft to MinGW internal (ANSI C).

Replace %F and %T in the format string. These specifiers are just
short-hand so just write them in full.

--debug and --release flags are unnecessary and trigger errors.

--pdb not supported and triggers a warning.

Capitalization matters here. We are now accepting this value from the
environment so we need to lower case that string.

Add an extra sanity check and status message for target CPU architecture
to help detect mismatches.

John Thacker authored Sep 22, 2021 and Wireshark GitLab Utility committed Sep 22, 2021

ETSI IP Datacast is another protocol that uses strings instead
of numeric payload types after the fmpt attribute. (ETSI TS 102 472,
ETSI TS 102 592). Since we're up to five special case strings to
check for, refactor the code a bit.

John Thacker authored Sep 19, 2021 and Wireshark GitLab Utility committed Sep 22, 2021

Protocol names can only be on the left hand side of filter expressions.
Commit ac0b1d42 (merge !4214) caused
unquoted strings that could be interpreted as either protocol names or
byte arrays to be parsed as the latter when on the RHS.  Further
relax by allowing unquoted strings on the RHS that can be interpreted as
protocol names to be treated as any generic unquoted string. (The
semantic checker will still prefer interpreting the string as a byte
array, if possible, to a generic string.)

This is useful for filter expressions of the sort "frame contains data",
where data should be interpreted as "data", i.e. "\x64\x61\x74\x61".
Long run this ideally should be fixed earlier, at the lex parser or
grammar checker.

João Valverde authored Sep 21, 2021 and João Valverde committed Sep 22, 2021

target_link_options() requires CMake >= 3.13.

Pau Espin Pedrol authored Sep 21, 2021 and pespin.shar@gmail.com committed Sep 21, 2021

As per TS 12.21 section 8.1.4 "Manufacturer-Defined O&M messages",
NOTE 1:
"""
The Length Indicator gives the length of the Manufacturer-defined O&M data field in the message
segment being transported which is less than or equal to 255 octet.
"""

Where the "Manufacturer-defined O&M data field" is the content AFTER the
"ManId Length Indicator" + "Manuf. Identifier" as can be seen in the
table of the same section.

This fix was tested against osmo-bts, which implements the ipaccess
manufacturer extensions.

Stig Bjørlykke authored Sep 21, 2021 and Wireshark GitLab Utility committed Sep 21, 2021

Profile files which is only used in Qt is not automatically registered
during startup and must be explicit registered.

Add profile_register_persconffile() to handle this registration.

João Valverde authored Sep 21, 2021 and Wireshark GitLab Utility committed Sep 21, 2021

Add a comment too.

João Valverde authored Sep 20, 2021 and Wireshark GitLab Utility committed Sep 21, 2021

For consistency's sake, I have not had any build errors that can
be attributed to this.

João Valverde authored Sep 20, 2021 and Wireshark GitLab Utility committed Sep 21, 2021

This seems relevant to MinGW-w64 from a quick look at the source.

Add all mesh models lighting opcodes dissector (chapter 6 of Mesh Models document). Closes #17578.