Skip to content
  • Maksim Salau's avatar
    dissectors: can: Handle CAN id flags · eaee7079
    Maksim Salau authored and AndersBroman's avatar AndersBroman committed
    The change adds support of CAN flags stored in ids.
    The flags allow dissectors to distinguish error frames,
    remote transmission request frames and identify id type used (either
    standard 11-bit or extended 29-bit).
    
    Addition of bit flags allowed to add more checks whether a CAN frame may
    be decoded by a particular dissector. I.e. some dissectors work only
    with 11-bit ids (CANopen, DeviceNet) some only with 29-bit (J1939,
    ISObus), others should be fine with bot types (OBD-II, ISO 15765).
    
    The change also fixes 2 bugs in the DeviceNet dissector:
    * removed byte swapping of CAN id (the pcap file seems to be broken;
      verified dissector operation with random traffic generated by cangen)
    * fixed "Warn Dissector bug, protocol DeviceNet, in packet N":
      added a default value for fragmented message type string value lookup.
    
    Bug: 15418
    Change-Id: I70e91130789bb3367fe19e51489cd34e97d678a6
    Reviewed-on: https://code.wireshark.org/review/31471
    
    
    Petri-Dish: Anders Broman <a.broman58@gmail.com>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: default avatarAnders Broman <a.broman58@gmail.com>
    eaee7079