Selenium2DriverTrait json_decode fails when fed default driver arguments
Describe the bug
package | version |
---|---|
DTT | 1.0.0-beta.1 |
PHP | 7.1.18 |
Using DTT v 1.0.0-beta.1, when running Selenium tests, I get the following error:
1) Drupal\Tests\bax_commercial\ExistingSiteJavascript\SmokeTest::testSmoke
Only arrays and Traversables can be unpacked
/var/www/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:108
/var/www/vendor/weitzman/drupal-test-traits/src/Selenium2DriverTrait.php:17
/var/www/vendor/weitzman/drupal-test-traits/src/GoutteTrait.php:45
/var/www/vendor/weitzman/drupal-test-traits/src/ExistingSiteBase.php:53
The issue appears to come from line 16 of Selenium2DriverTrait. When json_decode
is fed '["firefox", null, "http://localhost:4444/wd/hub"]'
, it comes back with null as a result, which is not unpackable via the splat operator.
EDIT: Specifically referring to the default value for DTT_MINK_DRIVER_ARGS provide in the example phpunit.xml file:
<env name="DTT_MINK_DRIVER_ARGS" value="['firefox', null, 'http://localhost:4444/wd/hub']"/>
To Reproduce Steps to reproduce the behavior:
- Add a test using the Selenium driver trait.
- Run the test.
Expected behavior I expected the test to run successfully.
Screenshots None.
Edited by Les Peabody