• Paolo Valente's avatar
    block, bfq: put async queues for root bfq groups too · 52257ffb
    Paolo Valente authored
    For each pair [device for which bfq is selected as I/O scheduler,
    group in blkio/io], bfq maintains a corresponding bfq group. Each such
    bfq group contains a set of async queues, with each async queue
    created on demand, i.e., when some I/O request arrives for it.  On
    creation, an async queue gets an extra reference, to make sure that
    the queue is not freed as long as its bfq group exists.  Accordingly,
    to allow the queue to be freed after the group exited, this extra
    reference must released on group exit.
    The above holds also for a bfq root group, i.e., for the bfq group
    corresponding to the root blkio/io root for a given device. Yet, by
    mistake, the references to the existing async queues of a root group
    are not released when the latter exits. This causes a memory leak when
    the instance of bfq for a given device exits. In a similar vein,
    bfqg_stats_xfer_dead is not executed for a root group.
    This commit fixes bfq_pd_offline so that the latter executes the above
    missing operations for a root group too.
    Reported-by: Holger Hoffstätte's avatarHolger Hoffstätte <holger@applied-asynchrony.com>
    Reported-by: default avatarGuoqing Jiang <gqjiang@suse.com>
    Tested-by: Holger Hoffstätte's avatarHolger Hoffstätte <holger@applied-asynchrony.com>
    Signed-off-by: Davide Ferrari's avatarDavide Ferrari <davideferrari8@gmail.com>
    Signed-off-by: default avatarPaolo Valente <paolo.valente@linaro.org>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
bfq-cgroup.c 33.6 KB