Commit e31aca49 authored by Eric Eastwood's avatar Eric Eastwood

Merge branch 'feature/1957-click-decorated-issue-to-open-link' into 'develop'

Click decorated issue to open in new tab

Closes #1957

See merge request gitlab-org/gitter/webapp!1217
parents 721feed5 9acbe373
# 19.14.0 - *upcoming*
- Remove rooms that now 404 from the homepage, https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1215
- Clicking decorated issue will open the link instead of opening the popover, https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1217
Developer facing:
......
......@@ -250,8 +250,6 @@ function bindAnchorToIssue(view, issueElement, type, provider, repo, issueNumber
var popover = createPopover(model, e.target);
popover.show();
Popover.singleton(view, popover);
e.preventDefault();
}
function showPopoverLater(e) {
......@@ -263,11 +261,9 @@ function bindAnchorToIssue(view, issueElement, type, provider, repo, issueNumber
}
// Hook up all of the listeners
issueElement.addEventListener('click', showPopover);
issueElement.addEventListener('mouseover', showPopoverLater);
view.once('destroy', function() {
issueElement.removeEventListener('click', showPopover);
issueElement.removeEventListener('mouseover', showPopoverLater);
});
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment