Skip to content

Remove filtered tell notification, warn on future cases, and retain early chat on the client

Imbrisrequested to merge
veloren/dev/veloren:imbris/misc-fixes-including-chat into master
  • By opening this merge request, you agree to release your code and all other changes under the GPL 3 license and to abide by the terms set by this license.
  • Migrations have been added if applicable (migrations are always necessary for removing/renaming item asset files)
  • Significant changes of this merge request have been added to the changelog.

I went to test the issue noted in !3406 (closed) and saw that the message wasn't even showing up in the chat box.

After some investigation I found that there is filtering on the server which only allows plain Content messages to be sent out when they are "from a player". This message was being blocked because even though the server generated it, it was shown as a message from a player. Because of the wording issues noted in !3406 (closed) and the fact that we already weren't showing this, I decided to just remove this message.

However, it was really difficult to track down that this was being filtered out. So I added some logging for this filtering but only when it wasn't a message directly from the client. Unfortunately, tracking if the message is "directly from the client" ended up being a somewhat disruptive change. I haven't thought of a better way to do this though.

While investigating this I also noticed that some initial messages sent by the server did not show up in the chat box because we don't retain those messages. This adds a queue in voxygen's GlobalState to store chat messages while not in the session state.

Merge request reports