Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • veloren veloren
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 444
    • Issues 444
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 61
    • Merge requests 61
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VelorenVeloren
  • velorenveloren
  • Merge requests
  • !1580

Fixed graceful shutdown countdown for servers running in Docker

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ben Wallis requested to merge xvar/fix-docker-shutdown-signal into master Nov 30, 2020
  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 1
  • By opening this merge request, you agree to release your code and all other changes under the GPL 3 license and to abide by the terms set by this license.
  • Migrations have been added if applicable
  • Significant changes of this merge request have been added to the changelog.
  • Changed server-cli/Dockerfile to use ENTRYPOINT to allow the veloren-server-cli process to receive signals sent by Watchtower. Previously our usage of CMD was resulting in the sh process being PID 1 rather than veloren-server-cli which meant the SIGUSR1 signal sent by Watchtower did not correctly initialise a 2 minute shutdown countdown .

From https://docs.docker.com/engine/reference/builder/#entrypoint The shell form prevents any CMD or run command line arguments from being used, but has the disadvantage that your ENTRYPOINT will be started as a subcommand of /bin/sh -c, which does not pass signals. This means that the executable will not be the container’s PID 1 - and will not receive Unix signals - so your executable will not receive a SIGTERM from docker stop .

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xvar/fix-docker-shutdown-signal