-
By opening this merge request, you agree to release your code and all other changes under the GPL 3 license and to abide by the terms set by this license. -
Migrations have been added if applicable -
Significant changes of this merge request have been added to the changelog.
- Changed
server-cli/Dockerfile
to useENTRYPOINT
to allow theveloren-server-cli
process to receive signals sent by Watchtower. Previously our usage ofCMD
was resulting in thesh
process being PID 1 rather thanveloren-server-cli
which meant theSIGUSR1
signal sent by Watchtower did not correctly initialise a 2 minute shutdown countdown .
From https://docs.docker.com/engine/reference/builder/#entrypoint The shell form prevents any CMD or run command line arguments from being used, but has the disadvantage that your ENTRYPOINT will be started as a subcommand of /bin/sh -c, which does not pass signals. This means that the executable will not be the container’s PID 1 - and will not receive Unix signals - so your executable will not receive a SIGTERM from docker stop .