Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
See what's new at GitLab
4
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Switch to GitLab Next
Sign in / Register
Toggle navigation
T
Telegram chart contest
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Test Cases
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Vasily Belolapotkov
Telegram chart contest
Commits
a6385000
Commit
a6385000
authored
Mar 23, 2019
by
Vasily Belolapotkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
improve plot inspector behavior on touch devices
parent
1f50605f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
29 additions
and
5 deletions
+29
-5
src/chart/chart-state.ts
src/chart/chart-state.ts
+11
-0
src/chart/plot-area.ts
src/chart/plot-area.ts
+17
-5
src/chart/plots-inspector.ts
src/chart/plots-inspector.ts
+1
-0
No files found.
src/chart/chart-state.ts
View file @
a6385000
...
...
@@ -231,6 +231,7 @@ export interface IChartStateController {
removeListener
:
(
eventName
:
string
,
listener
:
ChartEventListener
)
=>
void
;
showInspector
:
()
=>
void
;
hideInspector
:
()
=>
void
;
toggleInspector
:
()
=>
void
;
moveInspector
:
(
xOffset
:
number
)
=>
void
;
}
...
...
@@ -248,6 +249,7 @@ export function makeChartStateController(
removeListener
,
showInspector
,
hideInspector
,
toggleInspector
,
moveInspector
,
});
...
...
@@ -292,12 +294,15 @@ export function makeChartStateController(
const
nextXScale
=
xScaleChanged
?
xScale
:
state
.
xScale
;
const
nextXOffset
=
xOffsetChanged
?
xOffset
:
state
.
xOffset
;
state
.
setXViewRange
(
nextXScale
,
nextXOffset
);
hideInspector
();
fireEvent
(
'
xViewRangeChanged
'
);
fireEvent
(
'
yViewRangeChanged
'
);
}
function
toggleDataSetVisibility
(
dataSet
:
IDataSet
)
{
state
.
toggleDataSetVisibility
(
dataSet
);
state
.
setInspectorVisibility
(
false
);
hideInspector
();
fireEvent
(
'
yViewRangeChanged
'
);
fireEvent
(
'
dataSetVisibilityChanged
'
);
}
...
...
@@ -312,8 +317,14 @@ export function makeChartStateController(
fireEvent
(
'
inspectorVisibilityChanged
'
);
}
function
toggleInspector
()
{
state
.
setInspectorVisibility
(
!
state
.
inspectorIsActive
);
fireEvent
(
'
inspectorVisibilityChanged
'
);
}
function
moveInspector
(
xOffset
:
number
)
{
state
.
moveInspector
(
xOffset
);
state
.
setInspectorVisibility
(
true
);
fireEvent
(
'
moveInspector
'
);
}
}
src/chart/plot-area.ts
View file @
a6385000
...
...
@@ -12,6 +12,8 @@ export const makePlotArea: ChartComponentFactory<IPlotAreaProps> = function(
)
{
const
stateController
=
chartStateController
;
let
plotSize
:
ISize
;
let
touchStartTime
:
number
;
const
tapThresh
=
100
;
return
{
render
,
...
...
@@ -40,13 +42,12 @@ export const makePlotArea: ChartComponentFactory<IPlotAreaProps> = function(
function
attachInspectorHandlers
(
container
:
HTMLElement
)
{
container
.
addEventListener
(
'
mouseenter
'
,
handleMouseEnter
);
container
.
addEventListener
(
'
touchstart
'
,
handleMouseEnter
);
container
.
addEventListener
(
'
mouseleave
'
,
handleMouseLeave
);
container
.
addEventListener
(
'
touchend
'
,
handleMouseLeave
);
container
.
addEventListener
(
'
touchcancel
'
,
handleMouseLeave
);
container
.
addEventListener
(
'
mousemove
'
,
handleMouseMove
);
container
.
addEventListener
(
'
touchstart
'
,
handleTouchStart
);
container
.
addEventListener
(
'
touchend
'
,
handleTouchEnd
);
container
.
addEventListener
(
'
touchcancel
'
,
handleTouchEnd
);
container
.
addEventListener
(
'
touchmove
'
,
handleTouchMove
);
}
...
...
@@ -62,6 +63,17 @@ export const makePlotArea: ChartComponentFactory<IPlotAreaProps> = function(
moveInspector
(
evt
.
offsetX
);
}
function
handleTouchStart
()
{
touchStartTime
=
Date
.
now
();
}
function
handleTouchEnd
()
{
const
now
=
Date
.
now
();
if
(
now
-
touchStartTime
<
tapThresh
)
{
stateController
.
toggleInspector
();
}
}
function
handleTouchMove
(
evt
:
TouchEvent
)
{
if
(
evt
.
touches
.
length
!==
1
)
{
return
;
...
...
src/chart/plots-inspector.ts
View file @
a6385000
...
...
@@ -166,6 +166,7 @@ export function makePlotsInspector(
}
function
updateInspector
()
{
updateInspectorLineVisibility
();
updateInspectorXCoordinate
();
updateInspectorLine
();
updateInspectorPoints
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment