Skip to content
GitLab
Commit 48d08843 authored by Valéry Febvre's avatar Valéry Febvre
Browse files

[Card] Chapters list: Removed the possibility to enter in multiple selection... 

[Card] Chapters list: Removed the possibility to enter in multiple selection mode with a right mouse click.

Current implementation is incompatible with scrolling on touch screens.
parent 4b686dcb
Pipeline #365552502 passed with stage
in 6 minutes and 31 seconds
Hide whitespace changes
Inline Side-by-side
  • Valéry Febvre @valos ·
    Author Owner

    I have no idea how the click could be implemented differently. Since there are 3 other methods to enter in multi-selection mode, I don't think it's a big deal if this one is removed.

    Note: I did my tests with a Oneplus 6T (postmarketOS + Wayland + Gnome/Phosh).

    This may also fix #152 as I encountered the crash described here several times until this fix.

  • Mufeed Ali @mufeedali ·

    I don't think it would fix #152 since the crash in the report happens within the pager unless I'm missing something.

  • Mufeed Ali @mufeedali ·

    The crash described here is also very odd since return Gdk.EVENT_PROPAGATE should propagate events in the case that the conditions are not met...

  • Valéry Febvre @valos ·
    Author Owner

    There is no crash here.

    Yes, there is a return Gdk.EVENT_PROPAGATE that should propagate the events, but for some unknown reason, the scroll events are not.

    So when the user scrolls, either a row-activated event or a longpress event (if the scroll is long enough) is generated instead.

    NOTE: #152 was occurring with these unwanted row-activated events.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment