Follow-up from "Remove inline styling"
The following discussions from !59 (merged) should be addressed:
-
@differentreality started a discussion: (+1 comment) @pavlkara1 don't leave comments in the CSS. Either keep the code, or remove it. We have git to handle going back, if needed.
@oalagial do you want to review this?
-
@pavlkara1 commented on a discussion: (+1 comment) Here is the app in desktop, tablet and mobile mode in master and in this branch. (Many screenshots follow)
-
@differentreality started a discussion: (+1 comment) Clearly this is way too many screenshots for this MR... A good example for @kbarbounakis point that we should have more restricted changes which will also help us review faster, and merge faster (and without problems/conflicts!)
In any case, I believe we agreed with @kbarbounakis to keep this as is, and merge in due time - right @kbarbounakis ? Unfortunately we cannot merge this and introduce conflicts in small MRs which are fixing bugs :/
-
@kbarbounakis started a discussion: passed-grade exists in markup
<div class='col-3 col-md-2 passed-grade align-self-center ml-auto'> {{project.formattedGrade}} </div>
This class does not exist and should be removed from markup.
-
@kbarbounakis started a discussion: (+1 comment) All these internal classes should be removed in the future (let's keep them now to close merge request) e.g.
reg2__info-container__main-card
is a simple card with a default shadow. @universis/theme -which is going to be implemented in this project- already overridescard
to meet this proposal. So this class is useless.