session-migration still doesn't happen on some device
Step to reproduce: on FP4, upgrade from Xenial to Focal. Discovered that the first-time wizard is shown again, not the upgrade wizard. Inspecting /usr/share/session-migraion/scripts
show:
phablet@ubuntu-phablet:~$ ls -lhd /usr/share/session-migration/scripts
dr-xr-xr-x 1 root root 40 Jan 12 08:07 /usr/share/session-migration/scripts
phablet@ubuntu-phablet:~$ ls -lh /usr/share/session-migration/scripts/
ls: cannot access '/usr/share/session-migration/scripts/lomiri-thumbnailer-gsettings-schema-name-change.sh': Permission denied
ls: cannot access '/usr/share/session-migration/scripts/03_migrate_signon': Permission denied
ls: cannot access '/usr/share/session-migration/scripts/lomiri-cache-migration.sh': Permission denied
<snip>
total 0
-????????? ? ? ? ? ? 03_migrate_signon
-????????? ? ? ? ? ? address-book-app-name-change.sh
-????????? ? ? ? ? ? content-hub-gsettings-schema-name-change.sh
<snip>
This is caused by:
chmod 444 "${tmp_dir}" # Just to be safe
444 is r--r--r--
, and means that the folder's content will not be readable, even if the directory listing is.
The fix is to change this line to 555 (r-xr-xr-x
). However, For some users, this means that the scripts will run after they have been using the system for some time. We will have to take a special care to prevent the migration scripts from overwriting existing data...
I'm sorry...