Skip to content

redesign close element action and close selection mode

Daniel Frost requested to merge Danfro/terminal-app:closetext into master

I need to include the changes proposed in !85 (closed) in this MR because they affect the same files. I will close the other MR.

Part A (from !85 (closed)) When entering selection mode, the only way to exit that is by pressing the X icon in the header. This icon is easily missed.

This MR proposes to skip that icon but use the full bottom bar to exit selection mode. The text is changed to make it obvious for the user. This solution has been discussed in UX group, follow from here.

close selection

Part B

In AlternateActionPopover the last entry is named "Close App".

This is only true when there is just the last single terminal window open. Otherwise the action does close

  1. Split view
  2. tab
  3. other window
  4. the app

In many cases the last action in a popover is the popover close action. So if you don't READ the text, you end up closing the app. It is not obvious that in different situations the action does close different elements.

This MR does add a close button in the header that takes that action. It is colored as inactive when only one last terminal window is open. There will no longer be an "close app" action. The popovers last entry is changed to "close" and only used for closing the popover.

last window, button inactive

screenshot20201004_210621028

split view active, button active

screenshot20201004_210629106

Edited by Daniel Frost

Merge request reports