Add and Revert should respect Autoclose settings and not show any dialog boxes
What steps will reproduce the problem?
- Set "Autoclose Git.exe dialog" to "Auto-close if no errors."
- Create a new file in the Git repo.
- Right-click on it and select Add.
- Click OK at the file selection dialog.
- Click OK at the "Add Finished!" dialog.
- Right-click on the file and select Revert.
- Click OK at the file selection dialog.
- Click OK at the "Revert Finished!" dialog.
What is the expected output? What do you see instead?
The final "Add Finished" and "Revert Finished" dialogs should not show up, because TortoiseGit is set to autoclose if there are no errors.
However, they do show up, and you have to click OK. The need to click OK so many times is precisely why the autoclose setting was added.
What version of TortoiseGit and Git are you using? On what operating system?
TortoiseGit 1.8.16.0 x64. Tested on Windows 7 and Windows 10.
Please provide any additional information below.
The "Autoclose Git.exe dialog" setting only applies to the standard Git output dialog. "Add Finished" and "Revert Finished" are custom dialogs, so they do not obey that setting.
However, this distinction is of little interest to the user. The intention of the autoclose setting is to avoid seeing dialogs that report the success of a Git command. It shouldn't matter which command has been executed. All dialogs that report the result of a Git operation should respect that setting.
I only tested with Add and Revert, but there are probably many other such dialogs.