Show log crashes when commit with "encoding" in comment exists
By jakub.raj... on August 18, 2011 12:47 (imported from Google Code)
What steps will reproduce the problem?
1.Create commit with comment: "encoding"
2.Show log
What is the expected output? What do you see instead?
TortoiseGit shows small window with request to send dump file.
What version of the product are you using? On what operating system?
TortoiseGit 1.7.2.0 64bit; Windows 7 Prof. SP1 x64
The problem is in parsing header of commit. "Encoding" is expected as a keyword in header of commit with detailed info about commit encoding.
e.g.
-----------------------------------------------------------------
tree c41224ec217a0b11dedd1225ee09f2ae74a981d0
parent a2a698bebdf2c9582fa9f8f23af0b10a75d60b47
author Jakub Rajman <[email protected]> 1313666616 +0200
committer Jakub Rajman <[email protected]> 1313666616 +0200
encoding ISO-8859-1
comment of commit
-----------------------------------------------------------------
But if encoding missing in header and is presented in comment of commit then show log doesnt work.
e.g.
-----------------------------------------------------------------
tree c41224ec217a0b11dedd1225ee09f2ae74a981d0
parent a2a698bebdf2c9582fa9f8f23af0b10a75d60b47
author Jakub Rajman <[email protected]> 1313666616 +0200
committer Jakub Rajman <[email protected]> 1313666616 +0200
encoding comment of commit
-----------------------------------------------------------------
In attached file is patch for FIX of this issue.