Provide a confirm dialog instead of executing the revert operation directly (#3343) · Issues · TortoiseGit / TortoiseGit

Provide a confirm dialog instead of executing the revert operation directly

What steps will reproduce the problem?

show log of a repository
click the revert menu(I am trying to cherry-pick a commit from another branch, but click revert mistakenly)
you will found revert has been done, there is no chance to cancel the revert

What is the expected output? What do you see instead?
Expected:
When I click the revert menu, should popup a dialog to confirm the revert or let me cancel it

What I see:
There is no confirm dialog, and the revert has been done

What version of TortoiseGit and Git are you using? On what operating system?
TortoiseGit 2.7.2.0 (20181209-2258883b; C:\Program Files\TortoiseGit\bin)
git version 2.20.1.windows.1 (C:\Program Files\Git\bin; C:\Program Files\Git\mingw64; C:\Program Files\Git\mingw64\etc\gitconfig; C:\ProgramData\Git\config)

Microsoft Windows [Version 10.0.16299.967]

<!--
Please use the following template for reporting issues and feature requests. It helps to reduce the number of check backs. See also https://www.chiark.greenend.org.uk/~sgtatham/bugs.html why detailed reporting is necessary.

Please also check that
 * your issue is not already fixed in the latest stable AND preview release and that
 * a similar issue is not reported already (also check closed issues).

This comment can be removed after reading.
-->

**What steps will reproduce the problem?**

1. show log of a repository  
2. click the revert menu(I am trying to cherry-pick a commit from another branch, but click revert mistakenly)
3. you will found revert has been done, there is no chance to cancel the revert

**What is the expected output? What do you see instead?**  
Expected:  
When I click the revert menu, should popup a dialog to confirm the revert or let me cancel it 
  
What I see:  
There is no confirm dialog, and the revert has been done  
![image](/uploads/7b77a00d2b45096786e06ee921ed97cc/image.png)

**What version of TortoiseGit and Git are you using? On what operating system?**  
TortoiseGit 2.7.2.0 (20181209-2258883; C:\Program Files\TortoiseGit\bin)  
git version 2.20.1.windows.1 (C:\Program Files\Git\bin; C:\Program Files\Git\mingw64\; C:\Program Files\Git\mingw64\etc\gitconfig; C:\ProgramData\Git\config)  
  
Microsoft Windows [Version 10.0.16299.967]

Edited Sep 23, 2019 by Yue Lin Ho

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information