Properly indicate processing in diff dialog
What steps will reproduce the problem?
- Change some files in a larger project
- Show a diff of the changes (e.g. via right-click in Explorer > TortoiseGit > Diff)
What is the expected output? What do you see instead?
The diff dialog sometimes needs a quite long time to show the changed files (in my project up to a minute). While the changed files are searched, there is no hint that the files are processed, only once the view is updated, there is a hint "Please wait…". The buttons at the bottom of the dialog (Save as unified diff, Stash, Commit, Refresh, and OK) are shown and enabled, though clicking them causes the dialog to hang. Just after the changes got processed they work as expected.
After opening the dialog a second time, the changes are shown much faster, because the processing obviously only happens the first time the dialog is opened.
The "Please wait…" hint should always be shown while processing the changes (maybe even be rephrased to say what is actually happening and together with a throbber to indicate that the dialog doesn't hang). While processing, all buttons except the OK button should be disabled. And the OK button should also work while the files are processed ‒ or actually be replaced by the Cancel button, which is currently only shown while refreshing the view, as the user is cancelling the action.
What version of TortoiseGit and Git are you using? On what operating system?
TortoiseGit: 184.108.40.206 git: 2.18.0.windows.1