Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
TortoiseGit
TortoiseGit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 302
    • Issues 302
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 9
    • Merge requests 9
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • TortoiseGit
  • TortoiseGitTortoiseGit
  • Issues
  • #2308

Closed
Open
Created Aug 02, 2015 by Sven Strickroth@mrtuxOwner

Pressing ESC in the skip-worktree confirmation dialog box selects 'yes'

By ...@luminance.org on September 25, 2014 04:14 (imported from Google Code)


What steps will reproduce the problem?

  1. Accidentally (or intentionally, I guess!) click the skip-worktree option in the context menu for a file in the commit dialog box
  2. See 'Yes/No' confirmation dialog box
  3. Press ESC

What is the expected output? What do you see instead?
ESC should suppress the skip-worktree operation as if you had clicked no. ESC is universally used to cancel modal dialogs on windows.
Instead, tgit silently flags the file as skip-worktree and refreshes the commit window, hiding it.

What version of TortoiseGit and msysgit are you using? On
what operating system?
TortoiseGit 1.8.11.0 (C:\Program Files\TortoiseGit\bin)
git version 1.9.4.msysgit.0 (C:\Program Files (x86)\Git\bin)

Please provide any additional information below.
I think this is because you are marking the 'No' button as default, so Enter presumably activates it (which is probably what you want?) but I think as a result this makes the 'Yes' button the system Cancel button and as a result ESC triggers it.

Ideally files you've flagged as skip-worktree that were previously tracked in the repository should show up in the commit window with a flag like 'skip-worktree' in the status column (it's fine if you have a filter to hide them, I guess) since it's really easy to accidentally end up in a state where your files are invisible.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking