Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • TortoiseGit TortoiseGit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 380
    • Issues 380
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • TortoiseGitTortoiseGit
  • TortoiseGitTortoiseGit
  • Issues
  • #1555
Closed
Open
Issue created Aug 02, 2015 by Sven Strickroth@mrtuxOwner

Commit dialog fails to warn submodule dirty state

By @ch3cooli on December 01, 2012 13:11 (imported from Google Code)


This reflects a regression of Issue #1472 (closed) (commit message only),
as well as a bug in Issue #1411 (closed) (warn dirty submodule on commit).

What steps will reproduce the problem?
Case 1: Existing submodule

  1. Make an existing submodule dirty
  2. Commit the superproject using Commit Dialog

After fixing the problem for case 1, the problem for case 2 is unhidden
Case 2: New submodule

  1. Add a submodule
  2. Change a tracked file in the superproject
  3. Commit the superproject using Commit Dialog

What is the expected output? What do you see instead?
Case 1:
Expected: Warn that the submodule is dirty and ask the user if he wants to commit submodule.
Actual: No warning. The superproject is committed.

Case 2:
Expected: No warning. The superproject is committed.
Actual: Warn that submodule is dirty.

What version of TortoiseGit and msysgit are you using? On
what operating system?
TortoiseGit 1.7.15

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking