should not set SCI_SETFONTQUALITY to SC_EFF_QUALITY_LCD_OPTIMIZED which bypasses user preference
By [email protected] on August 17, 2012 18:59 (imported from Google Code)
What steps will reproduce the problem?
- disable cleartype on XP system (maybe newer systems as well?)
- enter text in commit message dialog
What is the expected output? What do you see instead?
I expect non-antialiased text. Instead I see cleartyped text.
What version of TortoiseGit and msysgit are you using? On
what operating system?
188.8.131.52 on windows 2003 x86
Please provide any additional information below.
If you are setting SC_EFF_QUALITY_LCD_OPTIMIZED in order to improve performance or appearance, then it should be under the if(use_directwrite).
Setting LCD optimized causes scintilla to ignore the user's OS preference for cleartype and force it to ON.
Additionally, there are at least two places where this is happening-one in SciEdit.cpp and one in TortoiseUDiff/MainWindow.cpp -- but the one in MainWindow.cpp is not doing the 'use2d' check for the Software\TortoiseGit\ScintillaDirect2D registry key. You should probably make that logic the same or unified.