Incorrect Date header in patch e-mail
By filip.nav... on July 27, 2009 07:59 (imported from Google Code)
What steps will reproduce the problem?
- Use "Create patch serial..." command
- Choose to "Send e-mails"
What is the expected output? What do you see instead?
The sent e-mail contains the Date: header which is generated using
_tcsftime function in HwSmtp.cpp. The format string used for _tcsftime
generates valid RFC 2822 Date headers only in C locale, but
TortoiseProc.cpp sets the locale to the current one, so the date generated
is incorrect.
Incorrect header:
Date: ne, 19 7 09 17:20:07 Central Europe Standard Time
Correct header
Date: Sun, 19 Jul 09 17:20:07 +0200