Memory leak @ bank - RAM filling then WoW crashing
What steps will reproduce the problem?
- AFK with bank open for a long(?) time.
What is the expected output? What do you see instead?
Garbage collection should prevent any leak from building up enough to crash the game. It appears it might not be for some players.
What was the level and class of the character you were on?
What version of the product are you using?
Please provide any additional information below.
Snipy2004 on CurseForge: https://wow.curseforge.com/projects/can-i-mog-it/issues/163
Snipy2004 3/22/2018 @ 6:13 PM
i have a full bank of items and equipment. If I leave this open for a long time because I'm sorting something, this addon "eats" all my 32 GB of RAM.
That must be a bug in the addon, because if i disable the addon the problem is gone!
When the RAM is full wow crashes!
@amiyuy 3/22/2018 @ 7:03 PM
Can you please include a list of all your addons, a screenshot of your bags and bank, and maybe a general list of what types of items you have?
We know that we have a leak with Pet Cages (no tooltip on them so it keeps trying), but garbage collection still works just fine and it resets the usage as it should.
Snipy2004 3/22/2018 @ 8:19 PM
If the option "Only unknown items" is deactivated, my RAM will not fill up completely, so the error must have something to do with it.
I have many shirts and tabards. Current Gear and Matz, Funitems and old weapons.
You can see it on the screenshot.
On the screenshot you can see how the ram looks after 2 minutes, after 3 minutes and after 5 minutes. Until the ram is full and wow crashes.
@amiyuy 3/22/2018 8:28 PM
Thank you very much, that is all very helpful! We'll look into the cause and let you know when it is fixed.
3/22/2018 @ 8:30 PM
I forgot to say that...
The problem comes only when the bank is open, if I have the normal inventory open is everything okay.
please try installing the addon https://wow.curseforge.com/projects/addon-usage
and then, in-game, open it with the command /addonusage and look at each addon's memory usage.
i have a nagging suspicion it might be another addon doing it... ages ago i had a similar issue with Atlasloot and i gave up on it.
Currently, Armory seems to be doing that too for me:
Bank closed: https://i.imgur.com/AMPNj0v.jpg
Bank open: https://i.imgur.com/MuYj5Ja.jpg
Unfortunately we cannot reproduce this on our machines. I have even tried using all the same addons (default settings) and letting my bags and bank sit open for 30 minutes, but saw no increase.
I have a couple of more questions and things to try to narrow it down.
- What are the exact steps you follow to make it happen?
- Does it happen on all characters?
- Does it happen every single time?
- How long does it take to increase to the point of crashing?
How long was there between those screenshots of the Task Manager window?(I see this answer now, 2 minutes, 3 minutes, 5 minutes)
- Please try with ONLY Can I Mog It enabled. Disable all other addons and see if the constant increase still happens.
- While doing so, mouse over the ? icon (Game Menu button) on your action bar and watch the memory that CIMI is using. Screenshots like you did with Task Manager would help.
If it still happens with ONLY CIMI enabled
- Could you attach your BagBrother.lua file and character name so we can see what items you have exactly?
- Could you attach a DXDiag? We might need to report this to Blizzard, since it shouldn't be possible for an addon to ignore automatic garbage collect. (How to create it)
- You can attach files to this ticket with the "Attach" button in the upper right.
If it does not happen when CIMI is the only addon enabled, then
- It is caused by a different addon.
- It is caused by an interaction between settings in CIMI and settings in one of your other addons.
- It is caused by a problem with the game client.
Snipy2004 3/28/2018 @ 10:41 AM
i have now tried the following:
i disabled all addons and looked at whether it is on the client so wow itself. The error does not occur there after 10 minutes.
Then i have activated only CIMI and see there after 2-3 minutes, the Ram is already filled with 11 GB. If I go with the mouse on the consumption of the addon memory there is no problem evident. Only in the TaskManager the RAM increases until it is full and crashes then my system.
Here are the pictures:
without addons : http://www.bilder-upload.eu/show.php?file=663205-1522251669.png
I have copied the path in Bagbrother but these are only itemsodes, no idea if they will help you.
That leaves 100% of CIMI. I have loaded it as described above as the only addon and the error occurs exactly as I said. Without the addon this does not happen.
Bagbrother Code.txt: https://media.forgecdn.net/attachments/226/604/bagbrother-code.txt
on the consumption of the addon memory there is no problem evident. Only in the TaskManager the RAM increases until it is full and crashes then my system.
hmm, i think you either have bad addon data saved in the SavedVariables (did you use "end task" on the game client when it was logging out and saving data?) or the game files themselves are corrupted.
please run a scan and repair from the battlenet client and then, in the Twitch app try to reinstall and reset the addon's SavedVariables. A simple addon reinstall will not delete the addon settings, you need to clear those separately because they are stored in a separate location from the addon files themselves.
Snipy2004 3/28/2018 @ 12:29 PM
I renamed my WTF folder and reinstalled CIMI.
I did that before taking the pictures.
The image without addons and the image with CIMI show that this addon is the problem.
Without addons it works without problems. If only CIMI is active, the error comes directly back.
There were no other addons active at the time and the RAM was full again.
Therefore, I can not understand your proposal.
But I will apply the step again and report you again.
@amiyuy 3/28/2018 @ 12:35 PM
Thank you very very much Snipy,
I do not think it would help to do a game repair or reset your addon settings, we think it might be something we are using that has caused a leak before (although slightly differently).
The BagBrother itemcodes are helpful because it might be triggered by a specific item you have.
Could you try a few older versions of the addon and see when it does or does not happen?
- 7.3.2v1.0: https://wow.curseforge.com/projects/can-i-mog-it/files/2495847
- 7.3.2v1.1: https://wow.curseforge.com/projects/can-i-mog-it/files/2501740
- 7.3.2v1.2: https://wow.curseforge.com/projects/can-i-mog-it/files/2504287
- 7.3.2v1.3: https://wow.curseforge.com/projects/can-i-mog-it/files/2504917
- 7.3.2v1.4: https://wow.curseforge.com/projects/can-i-mog-it/files/2510622
- 7.3.2v1.5: https://wow.curseforge.com/projects/can-i-mog-it/files/2514275
- Exit the game.
- Delete your CanIMogIt folder.
- Download and install one of the above versions.
- Open the game and see if the RAM fills up again.
This helps us narrow down the problem. Sorry there are so many.
Thank you very very much for the report and providing so much information.
Snipy2004 3/28/2018 12:49 PM
Repair and del WTF and Interface, new version of CIMI installed
I've just taken exactly the steps you said with Scan and Repair. For this I have again deleted the WTF and interface folders and reinstalled via Twitch client.There were no SavedVariables left. I am now testing the other versions that are above me.
Adrian 3/28/2018 @ 1:54 PM
headscratch can you please try
opening just the bank but none of the bag slots
opening only one of the
bankbags - open each one of them in turn, not all at once. Close one bank bag before opening the next one.
there's probably one weird item in there that causes this and opening bags sequentially like this could help to narrow the source down.
edit: i cut out
bankbecause it might be one item in inventory not in the bank that does this /edit
Snipy2004 3/28/2018 @ 8:16 PM
Sorry for my bad english, i use google translator for this. xD
i will test the various versions tomorrow. i try to find the item (s) causing the error. If it was because of it...
i have tested the problem on all my characters (~22). The characters with relatively many items on the bank generate the same error.
I'll get back to you tomorrow with the results.
@amiyuy 3/28/2018 @ 9:10 PM
Your English is great!
Thank you, checking the other characters helps because it is unlikely you have the same items on all characters.
I looked at the items in the BagBrother file and did not see any items that seemed like they would cause a problem. (You have a nice item collection!) bagbrother-code-itemsIdentified.txt
Hopefully a different version will help.
imtheminion 3/29/2018 @ 6:49 PM
I'm having the exact same issue. It started after I updated to the newest version of CIMI (7.3.5v1.7). If I revert back to the version before it, I have no issues. I'm doing a repair and removing my WTF directory as I type this to see if I can help pinpoint where the issue is coming from.
@amiyuy 3/29/2018 @ 7:08 PM
That's odd, imtheminion, because this ticket was opened when 7.3.2v1.6 was the most recent version. There were very few changes between 1.6 and 1.7.
Are you sure that you didn't previously have 1.5 or 1.4?
A repair and WTF reset probably won't work.
- Please try previous versions of the addon as listed in my previous post.
- What are the exact steps you take and what exactly happens?
imtheminion 3/29/2018 @ 7:24 PM
You're right, I didn't notice that this ticket was submitted during 7.3.2v1.6. I use the twitch app to keep all my addon up to date, so I know I've been on the newest version.
I'm really not sure when it triggers for me. I just notice it when I use a portal to go somewhere and it locks up. While, I do run with A LOT of addons, I noticed it the day I updated CIMI, and that was my only update that day. Ever since swapping back to 1.6, it's worked beautifully for me.
I'm about to try out some older versions and I see if I can find anything useful.
EDIT: I should clarify. Not just portals, but any loading screen.
imtheminion 3/29/2018 @ 8:59 PM
While using 7.3.5v1.6, it will slowly consume my RAM. There doesn't seem to be a specific point at which it starts that I can find. In about 20-30 minutes, it's taken about 8 GB of my ram, even when by itself. Using any version before that, I sit at a constant 3 GB of RAM usage, even with my 100+ of other addons activated;
@amiyuy 3/29/2018 @ 10:09 PM
Made a small change that hopefully fixes this.
Can you guys please try version 7.3.5v1.7a: https://wow.curseforge.com/projects/can-i-mog-it/files/2546531
Please let me know if there's any difference! Thank you.
imtheminion 3/29/2018 @ 11:19 PM
Whatever you changed seems to have fixed it for me. I'm back to sitting at 3GB with all my addon. Thank you!
Snipy2004 3/30/2018 @ 2:47 AM
apparently this alpha (7.3.5v1.7a) works for the moment. What have you changed? I have not tested the older versions because here in Germany are currently holidays and i had no time. ;-)
...but i will continue to test and run for an hour on various alts
@amiyuy 3/31/2018 @ 12:43 PM
The change we made was removing a second
CanIMogIt.DressUpModel = CreateFrame('DressUpModel')
When an item did not give us transmog data from C_TransmogCollection.GetItemInfo (most items will, but not all), we were redrawing the DressUpModel frame to try to make sure we were getting correct data from it. We thought that reusing the frame might be tainting the data. It seems that Blizzard was not releasing the memory from that model frame on some computers. We have an alternative data verification process now, so removing it should not break anything.
I'm going to close this issue for now since it seems to be fixed. If it happens again please let us know.
Thank you very very much for your report and testing, it helped a lot!
GitLab issue: #174 (closed)