Coupling with the HELM_REPOS
The helm template is designed to support 2 different scenarios:
- Deploying official, public charts from public repositories
- Packaging private charts based on local chart directories in the repo
However, If you are only working on scenario#2, the implementation still invokes add_helm_repositories
and tries to update the repository. In our case, where we have restricted outbound connectivities from the runners, these external repositories are not accessible and hence it fails. Setting the HELM_REPOS to empty value also fails due to missing NotNull check.
Proposal:
- Add the null check in
add_helm_repositories
before the update. - Make the impl decoupled to avoid invoking add_helm_repositories when not required e.g. helm_package, helm_lint, helm_score jobs.
Edited by Kiran Patel