Inconsistency between missingDaysTextView (n days ago), dateTextView and and ageBadge, if getDaysSinceLastBirthday() is within MAX_DAYS_AGO threshold
The case getDaysSinceLastBirthday() <= MAX_DAYS_AGO
is only handled in setupMissingDays
. There, it is actually handy to easily figure out for how long you missed a contacts birthday. I just got confused, when I noticed that the date 2 days ago
was not actually a Monday, as was stated in the dateTextView
of that same contact. Instead the date is a Monday next year, just as the Age is calculated for that birthday. I think this is intended behavior. So the text n days ago
is just a hint, but all age badges and date texts in the list always refer to future anniversaries, not past.
What about making the feature behind MAX_DAYS_AGO
more explicit and optionally enable the additional listing of past birthdays within that exact threshold at the top of the list? Those entries would contain the correct week day, age and missingDaysText for that past date, hence avoiding confusion through inconsistency.