[FIX] homepage: Hopeful fix for missing HomePage on new installs, also happens...

[FIX] homepage: Hopeful fix for missing HomePage on new installs, also happens when the HomePage has been deleted but it still set to be the `wikiHomePage`

lib/setup/wiki.php

@@ -27,8 +27,9 @@ if (
         || strstr($_SERVER['SCRIPT_NAME'], 'tiki-index_raw.php')
 ) {
     $check = false;
-    if (! isset($_REQUEST['page']) && ! isset($_REQUEST['page_ref_id']) && ! isset($_REQUEST['page_id'])) {
-        $_REQUEST['page'] = $userlib->get_user_default_homepage($user);
+    $userDefaultHomepage = $userlib->get_user_default_homepage($user);
+    if ((! isset($_REQUEST['page']) && ! isset($_REQUEST['page_ref_id']) && ! isset($_REQUEST['page_id'])) || $_REQUEST['page'] === $userDefaultHomepage) {
+        $_REQUEST['page'] = $userDefaultHomepage;
         $check = true;
     }
 

[Marc Laporte]

@jonnybradley I am wondering about failing tests here.

Thanks!

[Jonny Bradley]

The scheduler tests often fail randomly, i just re-ran the php 7.4 unit test pipeline and it passed without error. The error on this one was:

1) Tiki\Tests\Scheduler\ItemTest::testGetPreviousRunDateWithNoDelay
   Failed asserting that 1674644400 matches expected 1674648000.
   /builds/tikiwiki/tiki/lib/test/core/Scheduler/ItemTest.php:235

Looks like a timing issue?