fix #923: chainclients: ethereum: block scanner: match logs address (not tx to) to smart contract addresses

kiasakirequested to merge
kiasaki/thornode:923-issue into 923-issue

[WIP] fix #923 (closed): chainclients: ethereum: block scanner: match logs address (not tx to) to smart contract addressesSee #923 (closed)

Issue description copied for reference:

The way the Ethereum chain client checks that an interaction with the router's smart contract hapenned is based on the transaction's to field (see https://gitlab.com/thorchain/thornode/-/blob/chaosnet-multichain/bifrost/pkg/chainclients/ethereum/ethereum_block_scanner.go#L914)

This means that if the router contract get's called by an other contract the transaction's to field will be that of the other contract and Thorchain misses that transaction.

Being able to call the router from a smart contract would enable all kinds of "money lego" kind of interactions and make it easier to adopt for some.

The fix would entail looking at a transaction's receipt's logs for an interaction with the router (instead of just the to field)

Edited by Heimdall

Merge request reports