cherry pick bitcoin confirmation counting change to testnet-multichain , and...

Heimdallrequested to merge
696-issue into testnet-multichain

cherry pick bitcoin confirmation counting change to testnet-multichain , and also provide a way to update the vault

Closes #696 (closed)

context

Recently we invited more community node operators to join testnet-multichain. So we could grow the number of nodes to 6 and start to fund yggdrasil vaults. There is a bug on current testnet-multichain which include the internal transactions as part of the confirmation counting. So when the network start to grow from 2 nodes to 3 nodes , during the migration process , the migration tx has not been finalised before the vault churning. As a result , the vault migration process left some tBTC behind.

http://34.209.210.60:1317/thorchain/vault/BTC/tb1qcawdece9vufus5vuw9zzd7hm7wp320kvjt3vsq

The bug had been fixed a while ago on develop branch , but has fail to make to testnet-multichain release

testnet-multichain 0.17.0 is a cherry picked pull request which exclude internal tx from conf-count. Also this release will use store migration to salvage the tBTC from the retired vault.

Edited by Heimdall

Merge request reports