[Backwards-compatibility] V130-specific merged commits will need modification to V131

30f07d8e 'Prevent Multiple Coins in Send and Deposit' in the develop branch was a V130-specific (emergency) security commit;
https://gitlab.com/thorchain/thornode/-/commits/30f07d8e shows that there were two V130-specific merged commits after v1.129.0 .
(!3477 (merged) / !3481 (merged))

The gm.mgr !3477 (merged) commit might be fine as-is, but for consistency should ideally be treated like !3481 (merged).

https://gitlab.com/thorchain/thornode/-/commits/v1.130.0
shows that v1.130.0 (cc4ccc8d), a non-develop-branch (mainnet branch) commit,
did not have these V130-specific commits.

If V131 were later released from the develop branch, this V130 versioning would then retroactively change V130 behaviour,
plausibly resulting in sync failure
(specifically expected for !3481 (merged)
'Consistent updating of MaxGas and GasRate when a TxOutItem joins the outbound queue').
|
(A worst-case scenario being if consensus failure occurred when between 1/3rd and 2/3rds of Active nodes had updated to version 1.131.0,
thus half of Active nodes expecting incompatible current-version behaviour.)

Conveniently, since neither of these touched the deposit handler or send handler code (versioned in the security commit),
I currently predict it to be trivial to update the 1.130.0 versions for the txout manager and gas manager (in managers.go).

Double-checking the MR commits (prior to rebase which removed any empty placeholder commits):

https://gitlab.com/thorchain/thornode/-/commits/6120fef629091cfa520d8c8181da09686a41282e
https://gitlab.com/thorchain/thornode/-/commits/080e5cd22e3b25a5f529c1fc5b146970eb24858a
(Consistent with just the txout manager and gas manager updates being necessary.)

Checking for any other V130 or 1.130.0 references in the develop branch at present (30f07d8e): \

git reset --hard 30f07d8e
git grep -i V130

chain/avalanche/yarn.lock:  integrity sha512-i/qhuFsoNrnV130CSRYX/z4SlCfSQ4mHntti5yTmmQpt70xZKYZ57BsU0R29ueSQ9/P+aQrL2t2rqkQkAloUxg==
x/thorchain/handler_deposit.go:         return h.validateV130(ctx, msg)
x/thorchain/handler_deposit.go:func (h DepositHandler) validateV130(ctx cosmos.Context, msg MsgDeposit) error {
x/thorchain/handler_send.go:                    Register("1.130.0", MsgSendValidateV130).
x/thorchain/handler_send.go:func MsgSendValidateV130(ctx cosmos.Context, mgr Manager, msg *MsgSend) error {

(all there can be kept)
git grep 1.130.0

openapi/gen/api/openapi.yaml:  version: 1.130.0
openapi/openapi.yaml:  version: 1.130.0
version:1.130.0
x/thorchain/handler_deposit.go: case version.GTE(semver.MustParse("1.130.0")):
x/thorchain/handler_send.go:                    Register("1.130.0", MsgSendValidateV130).
x/thorchain/managers.go:        case version.GTE(semver.MustParse("1.130.0")):
x/thorchain/managers.go:        case version.GTE(semver.MustParse("1.130.0")):

A '[No logic change] Network version 1.131.0' commit will be necessary, and also the two managers.go cases for the VCUR calls for the txout and gas managers.

---

Confirming the Node-Launcher released version:

thorchain/devops/node-launcher@532cae23
'release 1.130.0 to mainnet'

  tag: mainnet-1.130.0
  hash: 427a2a817969d05398cdf4bd36c5e2ff5dddecb61ba6cd89bc9e59029b039f6c

docker run --rm registry.gitlab.com/thorchain/thornode@sha256:427a2a817969d05398cdf4bd36c5e2ff5dddecb61ba6cd89bc9e59029b039f6c thornode version --long | head -4 | tail -2

version: 1.130.0
commit: cc4ccc8deb9a1954db94ca909a413445b1246c27

This is indeed the expected 1.130.0-tag commit with the security commit and not the earlier V130-specific commits.

---

My specific code proposal: !3485 (merged)
'[V131-specific; Backwards-compatibility] Bump newTxOutStorageVCUR and newGasMgrVCUR versions from 1.130.0 to 1.131.0 #check-lint-warning'.