InactiveVault StatusSince is not set when InactiveVault is set in the observed txout handler
"status": "RetiringVault",
"status_since": 14561460,
"status": "InactiveVault",
"status_since": 14561460,
I was surprised by this as that I had thought !3164 (merged)'s use of UpdateStatus
had allowed InactiveVault height to be identifiable
(useful for investigating the timing of dropped reschedules or automatic refunds).
for _, vault := range retiring {
if !vault.HasFunds() {
vault.UpdateStatus(InactiveVault, ctx.BlockHeight())
if err := vm.k.SetVault(ctx, vault); err != nil {
However, I learned there is another place which needs to be changed, which I currently recommend doing.
https://gitlab.com/thorchain/thornode/-/blob/v1.127.0/x/thorchain/handler_observed_txout.go#L267-271
if !vault.HasFunds() && vault.Status == RetiringVault {
// we have successfully removed all funds from a retiring vault,
// mark it as inactive
vault.Status = InactiveVault
}
My specific code proposal: !3434 (merged)
'Set InactiveVault StatusSince when set from handler_observed_txout as well'.
Edited by Multipartite