nodeAddressValidatorAddressPairVCUR causes lint job failures on new Slasher version
'nodeAddressValidatorAddressPairVCUR' was added by me in !3196 (merged)
'MissBlockSignSlashPoints
for missing block signatures'.
Notably:
As always, feedback is welcome;
in particular format changes are likely appropriate, such as the unwieldy 'nodeAddressValidatorAddressPairVCUR'.
Something surprising to me is that this interfered with the lint job in future MRs for which the Slasher version was changed.
Upon seeing that !3266 (merged) had #check-lint-warning
added to its title, I looked at the lint job, and saw that the changes of VCUR to V124 (predicted) were causing lint to fail (unpredicted).
Rather than need every MR in future which changes the Slasher version to need #check-lint-warning
to pass
(making it harder to notice when one of those in fact has a serious lint problem),
I would much rather resolve this in a single MR so that #check-lint-warning
is not necessary for Slasher version changes.
My current proposal is to remove the 'VCUR' from 'nodeAddressValidatorAddressPairVCUR' and
(to prevent type-declaration duplication)
move it to a manager_slasher.go
file for unversioned code.
Specifically: !3273 (merged)
'For other MRs' lint jobs, make nodeAddressValidatorAddressPair unversioned and move it to manager_slasher.go
#check-lint-warning'.