Skip to content

BUG: tradetarget on Streamers assessing against sub-swap

works https://stagenet-thornode.ninerealms.com/thorchain/quote/swap?from_asset=ETH.ETH&to_asset=THOR.RUNE&amount=100000000&destination=sthor1nudqnvdfsf03emu3mue7z6gv8ewd6y2sel6p88&streaming_interval=9&streaming_quantity=99&from_address=0x46e3a8c8135647b48b2e82198e42e0c69eacbab8&tolerance_bps=10000

doesn't work https://stagenet-thornode.ninerealms.com/thorchain/quote/swap?from_asset=ETH.ETH&to_asset=THOR.RUNE&amount=100000000&destination=sthor1nudqnvdfsf03emu3mue7z6gv8ewd6y2sel6p88&streaming_interval=9&streaming_quantity=99&from_address=0x46e3a8c8135647b48b2e82198e42e0c69eacbab8&tolerance_bps=5000

{"error":"failed to simulate swap: emit asset 1562014106 less than price limit 77584931558"}

here, 1562014106 (subswap) is being assessed against 77584931558 (total swap) and will always fail

https://gitlab.com/thorchain/thornode/-/blob/develop/x/thorchain/querier_quotes.go?ref_type=heads#L575

the endpoint is called function quoteSimulateSwap with the amount of the sub-swap but without updating the msg.TradeTarget, so the simulation always fails if you set the param tolerance_bps for streaming swap estimation.