Streaming swap partial refunds do not call refundTx
This Issue is based on this discussion thread:
-
A partial swap emits a "swap" event but a partial refund emits no "swap" or "refund" event; use of
refundTx
would emit the "refund" event. -
refundTx
contains invariant-preserving code for when aTryAddTxOutItem
-error 'fail to refund' occurs, such as if the refund is insufficient to pay for the outbound fee.
By contrast, upon aTryAddTxOutItem
error current code skips the rest of that block's queuedEndBlock
swaps. -
Current code uses
OUT:
memos for both the partial-successful-swap outbound and the partial-refund outbound,
whereas use ofrefundTx
would distinguish the two by usingREFUND:
memos for partial refunds.
Specifically, I currently propose this code: !3016 (merged)
'Use refundTx for streaming swap partial refunds'.