[BUG] Bifrost fail to parse memo for BTC/BCH/LTC when memo is less than 5 characters
Community member on testnet report that when memo is very short , 4 characters or less, bifrost will ignore those transactions Upon investigation , it turns out that the response from bitcoin core has different format when the opreturn is short. for example: memo "tttt"
{
"value": 0,
"n": 0,
"scriptPubKey": {
"asm": "OP_RETURN 1953789044",
"hex": "6a0474747474",
"type": "nulldata"
}
},
bitcoin core rpc return asm as OP_RETURN 1953789044 , 1953789044 is not hex encoded string
when memo is longer , memo: "ADD:BTC.BTC"
{
"value": 0,
"n": 0,
"scriptPubKey": {
"asm": "OP_RETURN 4144443a4254432e425443",
"hex": "6a0b4144443a4254432e425443",
"type": "nulldata"
}
},
4144443a4254432e425443 is hex encoded, and can be decoded successfuly to "ADD:BTC.BTC"
For THORChain , no one should handcraft memo, and it should not be less than 4 characters, so this is an edge case , and will be fixed in the next release