• Jeff King's avatar
    git_extract_argv0_path: do nothing without RUNTIME_PREFIX · c1bb33c9
    Jeff King authored
    When the RUNTIME_PREFIX compile-time knob isn't set, we
    never look at the argv0_path we extract. We can push its
    declaration inside the #ifdef to make it more clear that the
    extract code is effectively a noop.
    This also un-confuses leak-checking of the argv0_path
    variable when RUNTIME_PREFIX isn't set. The compiler is free
    to drop this static variable that we set but never look at
    (and "gcc -O2" does so).  But the compiler still must call
    strbuf_detach(), since it doesn't know whether that function
    has side effects; it just throws away the result rather than
    putting it into the global.
    Leak-checkers which work by scanning the data segment for
    pointers to heap blocks would normally consider the block
    as reachable at program end. But if the compiler removes the
    variable entirely, there's nothing to find.
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
exec_cmd.c 3.17 KB