• Jeff King's avatar
    prefer "!=" when checking read_in_full() result · 61d36330
    Jeff King authored
    Comparing the result of read_in_full() using less-than is
    potentially dangerous, as a negative return value may be
    converted to an unsigned type and be considered a success.
    This is discussed further in 561598cfcf (read_pack_header:
    handle signed/unsigned comparison in read result,
    2017-09-13).
    
    Each of these instances is actually fine in practice:
    
     - in get-tar-commit-id, the HEADERSIZE macro expands to a
       signed integer. If it were switched to an unsigned type
       (e.g., a size_t), then it would be a bug.
    
     - the other two callers check for a short read only after
       handling a negative return separately. This is a fine
       practice, but we'd prefer to model "!=" as a general
       rule.
    
    So all of these cases can be considered cleanups and not
    actual bugfixes.
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    61d36330
csum-file.c 4.04 KB