Skip to content
  • Stefan Beller's avatar
    submodule: correct error message for missing commits · 2d94dd2f
    Stefan Beller authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    When a submodule diff should be displayed we currently just add the
    submodule objects to the main object store and then e.g. walk the
    revision graph and create a summary for that submodule.
    
    It is possible that we are missing the submodule either completely or
    partially, which we currently differentiate with different error messages
    depending on whether (1) the whole submodule object store is missing or
    (2) just the needed for this particular diff. (1) is reported as
    "not initialized", and (2) is reported as "commits not present".
    
    If a submodule is deinit'ed its repository data is still around inside
    the superproject, such that the diff can still be produced. In that way
    the error message (1) is misleading as we can have a diff despite the
    submodule being not initialized.
    
    Downgrade the error message (1) to be the same as (2) and just say
    the commits are not present, as that is the true reason why the diff
    cannot be shown.
    
    Signed-off-by: default avatarStefan Beller <sbeller@google.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    2d94dd2f