Skip to content

proto/michelson: using `pair` type instead of `*` for michelson pairs

Context

THis Merge request contains two changes that make the file Script_typed_ir more regular:

  • it uses (_,_)pair type instead of * for michelson pairs
  • it changes non-stack type variable `T to lowercase

The * type constructor is used both to construct stack type and to construct pairs type. The type ('a,'b) pair was introduced to make explicit the type of michelson pairs, this commit replace *by (_,_) pair at each point it makes sens.

Some `T where actually not stack variables despite their name, this commit change them for lowercase `t.

Manually testing the MR

The commits are splitted into the modification in the mli and ml files. The change in the ml files can thus be compiled with the old interface to check they are compatible, and the new interface can be compiled with the old implementation.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Julien

Merge request reports

Loading