Skip to content

Scoru,Proto: forbid double publish

Valentin Chaboche requested to merge vch9@scoru@forbid-double-publish into master

Context

We noticed on Mumbainet that rollup node operators could publish multiple times the same commitment. This indeed can be fixed in the rollup node, and should have already been fixed by now. In any case, making the operator fail in the protocol gives a better UX: the simulation will fail. Note that publishing N times a commitment is not a security issue, it just leads to a bad UX where one operator can pay for the fees of N operations.

Manually testing the MR

CI

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports