Proto/Michelson: cleanup legacy annotation management
Context
Field annotations are allowed on option
and parameter
, but only in legacy mode. Since no mainnet script seems to use this (the ones which did have been rewritten in !3730 (merged)) we can safely remove the code handling this to simplify a bit the translator. The simplification on option
in particular will ease the generation of the parse_ty
function (see nomadic-labs/michelson-polyrun!23) in Polyrun.
Manually testing the MR
- download a mainnet snapshot (rolling is enough)
- import it with
octez-node snapshot import
- extract the script with
dune exec devtools/get_contracts/get_contracts.exe -- /path/to/the/data/dir /path/to/output
- initialize a mockup base dir with
octez-client --mode mockup --base-dir /path/to/the/base/dir create mockup
- check that the scripts still typecheck using for each script
octez-client --mode mockup --base-dir /path/to/the/base/dir typecheck script /path/to/the/script --legacy
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR