Skip to content

scoru: Increase tick size to 64bit

Context

Fixes: #3589 (closed)

At the moment, ticks are int32. The proposal is to change it to int64, to gain some breathing room, now that the fast Wasm VM effort is starting.

The type of ticks is defined in the protocol, in Sc_rollup_repr.Number_of_ticks. At the moment it uses Bounded.Int32defined in the protocol environment, the proposal is to switch to Bounded.Int64.

Manually testing the MR

No new test is provided, so run existing tests or just CI. There a lot of regressions in tezt that were reset: in each case, either the storage has increased by 4 bytes, which is expected, or the pretty printing of the number of ticks is equivalent modulo ".

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Pierre-Emmanuel CORNILLEAU

Merge request reports