Scoru,Test: PBT the check dissection
Context
owner: @sribaroud / original author: @vch9
Addresses partially #3394 (closed)
To begin with, I'm moving the existing tests to test/pbt/test_refutation_game_legacy.ml
. II believe this file became messy through different iterations, and it will be much easier to integrate Thomas A. new tests in a clean state. So the idea would have 2 files; until every tests is ported to test/pbt/test_refutation_game.ml
.
The goal of this first merge request is to hard property-based test the dissection. We want to make sure that every invalid type of dissection is refused from the protocol. The good thing is that we win a dissection generator, which needs to be tweaked a bit to choose the correct section to dispute, and to introduce the "valid" state hashes (regarding the player's state).
Manually testing the MR
$ dune exec src/proto_alpha/lib_protocol/test/pbt/test_refutation_game.exe
Checklist
- n/a Document the interface of any function added or modified (see the coding guidelines)
- n/a Document any change to the user interface, including configuration parameters (see node configuration)
-
Provide automatic testing (see the testing guide). - n/a For new features and bug fixes, add an item in the appropriate changelog (
docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR