Skip to content

Proto: event emission is not a transaction

Mehdi Bouaziz requested to merge mehdi@event_emission into master

Context

!4656 (merged) adds event emission to Michelson through the EMIT instruction. It also adds event addresses in the Destination.t type, though it is not used as a Destination.t and Michelson scripts can do nothing with events addresses, especially CONTRACT do not work on them (and I failed doing it because of annotations, hence we would not be able to make TRANSFER_TOKENS work on events, as suggested in #3228 (closed)).

In this MR:

  • I rename Transaction_to_event to Event and change its kind so that it's not a transaction any more
    • leveraging @naih's work on splitting internal operation results, I didn't know it would be useful so quickly.
  • I remove the Event case from Destination
  • As a consequence: less failure cases that would not happen

@xf6 @tomjack Now I see no point in not including the tag in the hash. So it would be possible if you preferred it.

@shrmtv If we accept this change, it will need to be backported to proto-k to prevent people from storing event address.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Mehdi Bouaziz

Merge request reports