Remove redundant number_of_messages from commitments
Context
Since the introduction of a case for stuck states (denoted by None ) in the dissections, we know that it is possible to refute the claim that a given state is the last one because there are no more messages to read. Hence, a valid commitment defined by the pair (final state_hash + number_of_ticks) completely determines the number of messages consumed by the commitment: it must be the number of messages in the inbox between the level of the parent commitment and the level of the commitment itself.
I (@vch9) take over the mr, so if you want to assign someone to correct the code, please assign me.
Manually testing the MR
CI should stay green.
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR
Edited by Valentin Chaboche